Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1 and pending subscriptions #2122

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

rianhughes
Copy link
Contributor

closes #1389

This PR just takes the changes from Joshs PR, and applies them on top of main

Copy link

codecov bot commented Sep 8, 2024

Codecov Report

Attention: Patch coverage is 72.94118% with 46 lines in your changes missing coverage. Please review.

Project coverage is 78.52%. Comparing base (238c43c) to head (3c6bb60).

Files with missing lines Patch % Lines
rpc/events.go 63.76% 22 Missing and 3 partials ⚠️
node/node.go 30.00% 13 Missing and 1 partial ⚠️
sync/sync.go 63.15% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2122      +/-   ##
==========================================
+ Coverage   78.37%   78.52%   +0.14%     
==========================================
  Files         100      101       +1     
  Lines        9204     9330     +126     
==========================================
+ Hits         7214     7326     +112     
- Misses       1348     1364      +16     
+ Partials      642      640       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rianhughes rianhughes marked this pull request as ready for review September 8, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant