Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement cairo1 hint map #627

Merged
merged 9 commits into from
Aug 21, 2024
Merged

Implement cairo1 hint map #627

merged 9 commits into from
Aug 21, 2024

Conversation

MaksymMalicki
Copy link
Contributor

@MaksymMalicki MaksymMalicki commented Aug 13, 2024 •
edited by cicr99
Loading

Fix #621

@MaksymMalicki MaksymMalicki marked this pull request as draft August 13, 2024 02:40
@MaksymMalicki MaksymMalicki linked an issue Aug 14, 2024 that may be closed by this pull request
Build hint map for Cairo 1 #621
Closed
@MaksymMalicki MaksymMalicki marked this pull request as ready for review August 14, 2024 20:02
cicr99
cicr99 reviewed Aug 16, 2024
View reviewed changes
Copy link
Contributor

@cicr99 cicr99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good

cmd/cli/main.go Show resolved Hide resolved
cmd/cli/main.go Show resolved Hide resolved
@cicr99
Copy link
Contributor

cicr99 commented Aug 19, 2024

One last thought. Maybe we should add some unit tests for this parser, similar to pkg/hintrunner/zero/hintparser_test.go

@MaksymMalicki MaksymMalicki changed the title Implement hint map Implement cairo1 hint map Aug 20, 2024
@MaksymMalicki
Copy link
Contributor Author

Unit tests added, @cicr99 will you take a look?

@cicr99 cicr99 merged commit 47baa8f into main Aug 21, 2024
4 checks passed
@cicr99 cicr99 deleted the building_hint_map branch August 21, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cicr99 cicr99 cicr99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build hint map for Cairo 1
2 participants
@MaksymMalicki @cicr99