test_feature_extractor: add thread_lib dependency #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msys2's clang64 environment errors out due to undefined symbols with pthread. The non-clang environments are fine as gcc implicitly links pthread. mesonbuild/meson#13124 (comment) Signed-off-by: Christopher Degawa <[email protected]>
|
Compilation and test works locally. Also checked with ucrt64 and mingw64 and they all pass. |
|
I opened #1364 to fix the ffmpeg CI issue, do you know why the other tests may be failing? |
|
alright, I see that the other failure also has nothing to do with this PR, no idea how it got introduced 😞 This one LGTM, we will get it in after fixing that error |
nilfm99
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
msys2's clang64 environment errors out due to undefined symbols with pthread.
The non-clang environments are fine as gcc implicitly links pthread.
Fixes #1362