Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install python build dependencies in Makefile; simplify Dockerfile #1339

Merged
merged 4 commits into from
Mar 12, 2024

Conversation

nilfm99
Copy link
Collaborator

@nilfm99 nilfm99 commented Mar 12, 2024

This seems like a more streamlined user experience to make sure they have the pip dependencies installed when they run make or make install.

@nilfm99 nilfm99 requested a review from kylophone March 12, 2024 18:55
@nilfm99 nilfm99 changed the title Makefile: install python build dependencies Install python build dependencies in Makefile; simplify Dockerfile Mar 12, 2024
@kylophone
Copy link
Collaborator

lgtm, please squash

@nilfm99 nilfm99 merged commit a1b9fc0 into master Mar 12, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants