adm_dwt2_cy.pyx: fix cython warnings

[nilfm99]

Fixes the following warnings:

/home/coder/vmaf/.venv/lib/python3.10/site-packages/numpy/core/include/numpy/npy_1_7_deprecated_api.h:17:2: warning: #warning "Using deprecated NumPy API, disable it with " "#define NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION" [-Wcpp]
   17 | #warning "Using deprecated NumPy API, disable it with " \
      |  ^~~~~~~
In file included from vmaf/core/adm_dwt2_cy.c:1221:
vmaf/core/../../../libvmaf/src/mem.c:19: warning: "_POSIX_C_SOURCE" redefined
   19 | #define _POSIX_C_SOURCE 200112L
      | 
In file included from /usr/include/x86_64-linux-gnu/bits/libc-header-start.h:33,
                 from /usr/include/limits.h:26,
                 from /usr/lib/gcc/x86_64-linux-gnu/11/include/limits.h:203,
                 from /usr/lib/gcc/x86_64-linux-gnu/11/include/syslimits.h:7,
                 from /usr/lib/gcc/x86_64-linux-gnu/11/include/limits.h:34,
                 from /usr/include/python3.10/Python.h:11,
                 from vmaf/core/adm_dwt2_cy.c:37:
/usr/include/features.h:290: note: this is the location of the previous definition
  290 | # define _POSIX_C_SOURCE        200809L
      | 
vmaf/core/adm_dwt2_cy.c: In function ‘__pyx_pf_4vmaf_4core_11adm_dwt2_cy_adm_dwt2_cy’:
vmaf/core/adm_dwt2_cy.c:20302:39: warning: passing argument 1 of ‘init_dwt_band_d’ from incompatible pointer type [-Wincompatible-pointer-types]
20302 |   __pyx_v_data_top = init_dwt_band_d((&__pyx_v_aa_dwt2), __pyx_v_data_top, __pyx_v_buf_sz_one);
      |                                      ~^~~~~~~~~~~~~~~~~
      |                                       |
      |                                       struct __pyx_t_4vmaf_4core_11adm_dwt2_cy_adm_dwt_band_t *
In file included from vmaf/core/adm_dwt2_cy.c:1220:
vmaf/core/../../../libvmaf/src/feature/adm.c:53:48: note: expected ‘adm_dwt_band_t_d *’ but argument is of type ‘struct __pyx_t_4vmaf_4core_11adm_dwt2_cy_adm_dwt_band_t *’
   53 | static char *init_dwt_band_d(adm_dwt_band_t_d *band, char *data_top, size_t buf_sz_one)
      |                              ~~~~~~~~~~~~~~~~~~^~~~
vmaf/core/adm_dwt2_cy.c:20563:29: warning: passing argument 2 of ‘adm_dwt2_d’ from incompatible pointer type [-Wincompatible-pointer-types]
20563 |     adm_dwt2_d(__pyx_v_aa, (&__pyx_v_aa_dwt2), __pyx_v_ind_y, __pyx_v_ind_x, __pyx_v_w, __pyx_v_h, __pyx_v_curr_ref_stride, __pyx_v_buf_stride);
      |                            ~^~~~~~~~~~~~~~~~~
      |                             |
      |                             struct __pyx_t_4vmaf_4core_11adm_dwt2_cy_adm_dwt_band_t *
In file included from vmaf/core/adm_dwt2_cy.c:1219:
vmaf/core/../../../libvmaf/src/feature/adm_tools.c:943:60: note: expected ‘const adm_dwt_band_t_d *’ but argument is of type ‘struct __pyx_t_4vmaf_4core_11adm_dwt2_cy_adm_dwt_band_t *’
  943 | void adm_dwt2_d(const double *src, const adm_dwt_band_t_d *dst, int **ind_y, int **ind_x, int w, int h, int src_stride, int dst_stride)
      |                                    ~~~~~~~~~~~~~~~~~~~~~~~~^~~
x86_64-linux-gnu-gcc -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -g -fwrapv -O2 -Wl,-Bsymbolic-functions -g -fwrapv -O2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 build/temp.linux-x86_64-3.10/vmaf/core/adm_dwt2_cy.o -o ./vmaf/core/adm_dwt2_cy.cpython-310-x86_64-linux-gnu.so

At least on the system I'm working on, this also introduces a new warning, due to a redefinition of _POSIX_C_SOURCE in both the header Python.h and our file libvmaf/src/mem.c. We can avoid this by wrapping our statement in #ifndef/#endif, will do this on a follow up commit.

In file included from vmaf/core/adm_dwt2_cy.c:1228:
vmaf/core/../../../libvmaf/src/mem.c:19: warning: "_POSIX_C_SOURCE" redefined
   19 | #define _POSIX_C_SOURCE 200112L
      | 
In file included from /usr/include/x86_64-linux-gnu/bits/libc-header-start.h:33,
                 from /usr/include/limits.h:26,
                 from /usr/lib/gcc/x86_64-linux-gnu/11/include/limits.h:203,
                 from /usr/lib/gcc/x86_64-linux-gnu/11/include/syslimits.h:7,
                 from /usr/lib/gcc/x86_64-linux-gnu/11/include/limits.h:34,
                 from /usr/include/python3.10/Python.h:11,
                 from vmaf/core/adm_dwt2_cy.c:43:
/usr/include/features.h:290: note: this is the location of the previous definition
  290 | # define _POSIX_C_SOURCE        200809L

[nilfm99]

To fix: this fails on Mac with the macro that I added to bypass the warning:

vmaf/core/adm_dwt2_cy.c:2928:42: error: no member named 'data' in 'struct tagPyArrayObject'
  __pyx_v_aa = ((double *)__pyx_v_a_buf->data);
                          ~~~~~~~~~~~~~  ^

[nilfm99]

Removed the macro, now only the following two warnings are fixed:

vmaf/core/adm_dwt2_cy.c:3206:38: warning: incompatible pointer types passing 'struct __pyx_t_4vmaf_4core_11adm_dwt2_cy_adm_dwt_band_t *' to parameter of type 'adm_dwt_band_t_d *' (aka 'struct adm_dwt_band_t_d *') [-Wincompatible-pointer-types]
  __pyx_v_data_top = init_dwt_band_d((&__pyx_v_aa_dwt2), __pyx_v_data_top, __pyx_v_buf_sz_one);
                                     ^~~~~~~~~~~~~~~~~~
vmaf/core/../../../libvmaf/src/feature/adm.c:53:48: note: passing argument to parameter 'band' here
static char *init_dwt_band_d(adm_dwt_band_t_d *band, char *data_top, size_t buf_sz_one)
                                               ^
vmaf/core/adm_dwt2_cy.c:3467:28: warning: incompatible pointer types passing 'struct __pyx_t_4vmaf_4core_11adm_dwt2_cy_adm_dwt_band_t *' to parameter of type 'const adm_dwt_band_t_d *' (aka 'const struct adm_dwt_band_t_d *') [-Wincompatible-pointer-types]
    adm_dwt2_d(__pyx_v_aa, (&__pyx_v_aa_dwt2), __pyx_v_ind_y, __pyx_v_ind_x, __pyx_v_w, __pyx_v_h, __pyx_v_curr_ref_stride, __pyx_v_buf_stride);
                           ^~~~~~~~~~~~~~~~~~
vmaf/core/../../../libvmaf/src/feature/adm_tools.c:943:60: note: passing argument to parameter 'dst' here
void adm_dwt2_d(const double *src, const adm_dwt_band_t_d *dst, int **ind_y, int **ind_x, int w, int h, int src_stride, int dst_stride)