Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ShowsUIOnMainThread, refactor UI coordination #609

Merged
merged 42 commits into from
Aug 17, 2024
Merged

Remove ShowsUIOnMainThread, refactor UI coordination #609

merged 42 commits into from
Aug 17, 2024

Commits on Aug 11, 2024

  1. Rip out ShowsUIOnMainThread property 

    WIP, but anything related to this will go into the UI lib(s)

Co-Authored-By: kenjiuno <[email protected]>
    @Deadpikle @kenjiuno
    Deadpikle and kenjiuno committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    8f1ccba View commit details
    Browse the repository at this point in the history

  2. Avalonia never supported ShowsUIOnMainThread

    @Deadpikle
    Deadpikle committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    0aeea45 View commit details
    Browse the repository at this point in the history

  3. WPF UI lib UIFactory update; untested/uncompiled atm

    @Deadpikle
    Deadpikle committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    e3eaeff View commit details
    Browse the repository at this point in the history

  4. Default to showing WPF UI on main thread

    @Deadpikle
    Deadpikle committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    e850e0c View commit details
    Browse the repository at this point in the history

  5. Only get temp file name on update window response if needed

    @Deadpikle
    Deadpikle committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    3127e1d View commit details
    Browse the repository at this point in the history

  6. Rough update of winforms for no ShowsUIOnMainThread

    @Deadpikle
    Deadpikle committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    ede29fa View commit details
    Browse the repository at this point in the history

  7. Bump a couple samples to net8

    @Deadpikle
    Deadpikle committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    cede4fd View commit details
    Browse the repository at this point in the history

  8. Remove ShowsUIOnMainThread from some samples

    @Deadpikle
    Deadpikle committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    8126044 View commit details
    Browse the repository at this point in the history

  9. Update README.md

    @Deadpikle
    Deadpikle committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    fb25947 View commit details
    Browse the repository at this point in the history

  10. Use FileVersion as backup for AssemblyVersion

    @Deadpikle
    Deadpikle committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    3f65950 View commit details
    Browse the repository at this point in the history

  11. Fix messed up header on win forms

    @Deadpikle
    Deadpikle committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    4f3045b View commit details
    Browse the repository at this point in the history

  12. Make other samples work w/no ShowsUIOnMainThread

    @Deadpikle
    Deadpikle committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    7a26bad View commit details
    Browse the repository at this point in the history

  13. Make event funcs work even without UIFactory 

    ...this kind of resets things almost back to how they were before with the _syncContext. So...do we roll back to not using the UIFactory? Ugh....need to think this through more.
    @Deadpikle
    Deadpikle committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    74eadb0 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Move UI threading actions to IUIThreadManager

    @Deadpikle
    Deadpikle committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    1722ef6 View commit details
    Browse the repository at this point in the history

  2. Only use UI threading if UIFactory is IUIThreadManager

    @Deadpikle
    Deadpikle committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    4eac532 View commit details
    Browse the repository at this point in the history

  3. Add additional logs

    @Deadpikle
    Deadpikle committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    d9c4194 View commit details
    Browse the repository at this point in the history

  4. Update README.md

    @Deadpikle
    Deadpikle committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    0fd234b View commit details
    Browse the repository at this point in the history

  5. Rename CallFuncConsideringUIThreads to PerformUIAction

    @Deadpikle
    Deadpikle committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    9548429 View commit details
    Browse the repository at this point in the history

  6. Update NetSparkleUpdater.sln

    @Deadpikle
    Deadpikle committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    9cbbc89 View commit details
    Browse the repository at this point in the history

  7. Another rename for 100% clarity 

    "Main Thread" is the thread the SparkleUpdater was started on
    @Deadpikle
    Deadpikle committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    26e0cff View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Actual downloader now triggers download started

    @Deadpikle
    Deadpikle committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    9c7b72a View commit details
    Browse the repository at this point in the history

  2. StartLoop now returns Task

    @Deadpikle
    Deadpikle committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    a21b13e View commit details
    Browse the repository at this point in the history

  3. Make IUpdateDownloader.StartFileDownload return Task

    @Deadpikle
    Deadpikle committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    f915efb View commit details
    Browse the repository at this point in the history

  4. Rename func

    @Deadpikle
    Deadpikle committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    3148a88 View commit details
    Browse the repository at this point in the history

  5. Await some Sparkle StartLoop calls

    @Deadpikle
    Deadpikle committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    d8dab0d View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Add sample for multithreading Windows Forms app 

    Allows you to close main window and other forms for NetSparkleUpdater keep going.
    @Deadpikle
    Deadpikle committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    1a4e988 View commit details
    Browse the repository at this point in the history

  2. WInForms download progress bars start indeterminate

    @Deadpikle
    Deadpikle committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    149a1af View commit details
    Browse the repository at this point in the history

  3. Rip out PerformMainThreadAction 

    Don't need it. NetSparkleUpdater assumes main thread use now, which most users will be doing anyway.
    @Deadpikle
    Deadpikle committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    fd4757e View commit details
    Browse the repository at this point in the history

  4. Check invoke req'd on net core win forms UpdateAvailableWindow.Show

    @Deadpikle
    Deadpikle committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    05273fd View commit details
    Browse the repository at this point in the history

  5. Remove now-unnecessary PerformUIAction funcs

    @Deadpikle
    Deadpikle committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    ee481d1 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Re-add sync context for background loop calling to UI thraed

    @Deadpikle
    Deadpikle committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    438c687 View commit details
    Browse the repository at this point in the history

  2. Call UpdateDetected from loop to main thread

    @Deadpikle
    Deadpikle committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    855baf6 View commit details
    Browse the repository at this point in the history

  3. Pause a few seconds at start of worker loop

    @Deadpikle
    Deadpikle committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    4c5bde7 View commit details
    Browse the repository at this point in the history

  4. Add UpdateDetectedAsync 

    See #571
    @Deadpikle
    Deadpikle committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    5558735 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2024

  1. Adjust behavior so calling check for updates shows UI

    @Deadpikle
    Deadpikle committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    4c04cdb View commit details
    Browse the repository at this point in the history

  2. ReleaseNotesGrabber.DownloadReleaseNotes catches more exceptions

    @Deadpikle
    Deadpikle committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    52563dd View commit details
    Browse the repository at this point in the history

  3. Remove some unneeded params

    @Deadpikle
    Deadpikle committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    2e3a510 View commit details
    Browse the repository at this point in the history

  4. Update README.md

    @Deadpikle
    Deadpikle committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    900bb77 View commit details
    Browse the repository at this point in the history

  5. Update UPGRADING.md

    @Deadpikle
    Deadpikle committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    9733e6e View commit details
    Browse the repository at this point in the history

  6. Add Directory.Build.props for easier Avalonia version management

    @Deadpikle
    Deadpikle committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    a53b796 View commit details
    Browse the repository at this point in the history

  7. Better logging for loop breaking on first time run

    @Deadpikle
    Deadpikle committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    ec90908 View commit details
    Browse the repository at this point in the history

  8. Update UPGRADING.md

    @Deadpikle
    Deadpikle committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    3addab2 View commit details
    Browse the repository at this point in the history