Revert "Make async void -> async Task"

This reverts commit e0e3466.
NetSparkleUpdater · Dec 7, 2023 · 8094fd1 · 8094fd1
1 parent e0e3466
commit 8094fd1
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/src/NetSparkle/SparkleUpdater.cs b/src/NetSparkle/SparkleUpdater.cs
@@ -489,7 +489,7 @@ public void StartLoop(bool doInitialCheck, bool forceInitialCheck)
         /// <param name="forceInitialCheck">if <paramref name="doInitialCheck"/> is true, whether the first check
         /// should happen even if the last check was within the last <paramref name="checkFrequency"/> interval</param>
         /// <param name="checkFrequency">the interval to wait between update checks</param>
-        public async Task StartLoop(bool doInitialCheck, bool forceInitialCheck, TimeSpan checkFrequency)
+        public async void StartLoop(bool doInitialCheck, bool forceInitialCheck, TimeSpan checkFrequency)
         {
             if (ClearOldInstallers != null)
             {
@@ -1025,7 +1025,7 @@ private void CreateAndShowProgressWindow(AppCastItem castItem, bool shouldShowAs
             thread.Start();
         }
 
-        private async Task ProgressWindowCompleted(object sender, DownloadInstallEventArgs args)
+        private async void ProgressWindowCompleted(object sender, DownloadInstallEventArgs args)
         {
             if (args.ShouldInstall)
             {
@@ -1211,7 +1211,7 @@ private void OnDownloadFinished(object sender, AsyncCompletedEventArgs e)
         /// </summary>
         /// <param name="item">AppCastItem to install</param>
         /// <param name="installPath">Install path to the executable. If not provided, will ask the server for the download path.</param>
-        public async Task InstallUpdate(AppCastItem item, string installPath = null)
+        public async void InstallUpdate(AppCastItem item, string installPath = null)
         {
             ProgressWindow?.SetDownloadAndInstallButtonEnabled(false); // disable while we ask if we can close up the software
             if (await AskApplicationToSafelyCloseUp())
@@ -1833,7 +1833,7 @@ private async Task CallFuncConsideringUIThreadsAsync(Func<Task> action)
             }
         }
 
-        private async Task OnUpdateWindowUserResponded(object sender, UpdateResponseEventArgs args)
+        private async void OnUpdateWindowUserResponded(object sender, UpdateResponseEventArgs args)
         {
             LogWriter.PrintMessage("Update window response: {0}", args.Result);
             var currentItem = args.UpdateItem;
@@ -1890,7 +1890,7 @@ await CallFuncConsideringUIThreadsAsync(async () =>
         /// <summary>
         /// Loop that occasionally checks for updates for the running application
         /// </summary>
-        private async Task OnWorkerDoWork(object sender, DoWorkEventArgs e)
+        private async void OnWorkerDoWork(object sender, DoWorkEventArgs e)
         {
             // store the did run once feature
             bool goIntoLoop = true;
@@ -2101,7 +2101,7 @@ private void OnWorkerProgressChanged(object sender, ProgressChangedEventArgs e)
         /// If the user is not downloading silently, the update UI will be shown.
         /// </summary>
         /// <param name="updates">updates to be installed. If null, nothing will happen.</param>
-        private async Task UpdatesHaveBeenDownloaded(List<AppCastItem> updates)
+        private async void UpdatesHaveBeenDownloaded(List<AppCastItem> updates)
         {
             if (updates != null)
             {