Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support new import #525

Closed
wants to merge 1 commit into from
Closed

Conversation

mikejgray
Copy link
Contributor

Description

Moves to the new import location for get_local_settings, supporting ovos-utils 0.1.0

Issues

N/A

Other Notes

2024-05-11 14:43:03.589 - skills - ovos_plugin_manager.utils:find_plugins:124 - ERROR - Failed to load plugin entry point EntryPoint(name='skill-launcher.neongeckocom', value='skill_launcher:LauncherSkill', group='ovos.plugin.skill'): No module named 'ovos_utils.skills.settings'; 'ovos_utils.skills' is not a package
2024-05-11 14:43:03.864 - skills - ovos_plugin_manager.utils:find_plugins:124 - ERROR - Failed to load plugin entry point EntryPoint(name='skill-spelling.neongeckocom', value='skill_spelling:SpellingSkill', group='ovos.plugin.skill'): No module named 'ovos_utils.skills.settings'; 'ovos_utils.skills' is not a package
2024-05-11 14:43:04.033 - skills - ovos_plugin_manager.utils:find_plugins:124 - ERROR - Failed to load plugin entry point EntryPoint(name='skill-speak.neongeckocom', value='skill_speak:SpeakSkill', group='ovos.plugin.skill'): No module named 'ovos_utils.skills.settings'; 'ovos_utils.skills' is not a package

@mikejgray
Copy link
Contributor Author

It looks like the new import changes the way this is handled...need to look that over and see if we need to retain the ability to pass a path. I'm not familiar enough with this portion of the codebase to say right now

@mikejgray mikejgray marked this pull request as draft May 12, 2024 01:27
@mikejgray mikejgray requested a review from NeonDaniel May 12, 2024 01:27
@JarbasAl
Copy link
Contributor

JarbasAl commented May 12, 2024

i dont think these imports are the same thing, they do share the name but are independent utils....

in backend client context this is used to manage remote settings, merge etc, it is a helper tool

in skills context this + save_settings() were util methods used by MycroftSkill class, simply replaced by direct usage of self.settings class, eg, self.settings.store()

(this is actually a intended regression, mycroft was like this, introduced new util, we reverted back to original implementation)

the last OVOS usage of this is here OpenVoiceOS/OVOS-workshop@dev/ovos_workshop/skills/mycroft_skill.py#L214

if you need these utils, just copy paste the code from here OpenVoiceOS/ovos-utils@28badf8 to neon_utils directly

@NeonDaniel
Copy link
Member

NeonDaniel commented Oct 8, 2024

Superseded by #534

@NeonDaniel NeonDaniel closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants