Loosen ovos-utils dependency to allow 0.1 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarbasAl
reviewed
Apr 2, 2024
| @@ -3,4 +3,4 @@ click-default-group~=1.2 | |||
| mycroft-messagebus-client~=0.10 | |||
There was a problem hiding this comment.
idk if it belong in another PR, but this should also be dropped in favor of ovos-bus-client
There was a problem hiding this comment.
We need some method to create a client without loading the full config stack first. I had refactored to use ovos-bus-client but had to revert changes because it would take several seconds to instantiate a client object
JarbasAl
approved these changes
Apr 2, 2024
builderjer
approved these changes
Apr 2, 2024
Merged
NeonDaniel
added a commit
that referenced
this pull request
Jun 17, 2024
* If omitting session context, include length of omitted json for debugging (#38) Co-authored-by: Daniel McKnight <[email protected]> * Increment Version to 0.2.3a1 * Loosen ovos-utils dependency to allow 0.1 (#41) Co-authored-by: Daniel McKnight <[email protected]> * Increment Version to 0.2.3a2 * Increment Version to 0.3.0 * Update Changelog --------- Co-authored-by: Daniel McKnight <[email protected]> Co-authored-by: Daniel McKnight <[email protected]> Co-authored-by: NeonDaniel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues
Closes #39
Closes #40
Other Notes
Will also require an alpha version of
neon-utilsto allow ovos-utils 0-.1.x NeonGeckoCom/neon-utils#507