Update neon-audio to resolve playback errors #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update default config to use old audioservice
NeonDaniel
force-pushed
the
PATCH_AudioBug
branch
from
fb85e4d
to
e2f61cb
Compare
NeonDaniel
changed the title
JarbasAl
reviewed
Sep 16, 2024
| @@ -1,3 +1,6 @@ | |||
| # TODO: Below adding intermediate support for ovos-audio 0.x | |||
| enable_old_audioservice: True | |||
There was a problem hiding this comment.
this is the default value already in OVOS, no need for this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates neon-audio dependency to a version that includes backwards-compat. working audio playback
Updates default config to use the legacy audio service
Issues
NeonGeckoCom/neon_audio#177
Other Notes
Audio will be updated again to use the new audio service, but only after skills have been updated for compat. with 0.x OVOS dependencies and tested against this release