Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to open pull popup from within log view #970

Closed
wants to merge 1 commit into from

Conversation

gollth
Copy link
Contributor

@gollth gollth commented Nov 25, 2023

Another small thing, that worked in Magit: When pressing p in the log graph view you could open the "pull" popup. On my setup this fails with:

image

Added this open to the pop up mappings in log_view:
pull-popup gif

@CKolkey
Copy link
Member

CKolkey commented Nov 26, 2023

Ah, ok! The implementation is actually even more simple than you have it - we don't do anything with the passed in commit, so you can omit that second function as an argument entirely. Since it's so simple I just went ahead and did it: #972

Thanks for pointing that out :)

@CKolkey CKolkey closed this Nov 26, 2023
@gollth
Copy link
Contributor Author

gollth commented Nov 27, 2023

Ah okay, good to know. Thanks for fixing!

@gollth gollth deleted the pull-popup-in-log branch November 27, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants