Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph colors #934

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Graph colors #934

merged 2 commits into from
Nov 14, 2023

Conversation

gollth
Copy link
Contributor

@gollth gollth commented Nov 13, 2023

Hi there,

first of all, thanks again for this amazing package! Long time emacs user decided to switch to nvim just because of you ^^

I was trying to configure the look and feel of the log graph view of neogit to match more the original color scheme of magit:

magit-graph

However with my config the colors of neogit look rather dull:

neogit-graph

I tried to configure the NeogitGraph* highlight groups without success. After digging a bit through the code of neogit, I noticed that you use Macro and String highlight groups for local/remote branch names. Maybe these could reuse the NeogitBranch & NeogitRemote highlight groups instead?

I don't have much experience with Lua or highlight groups, so please let me know if there is another (better?) way to configure this =)

@CKolkey
Copy link
Member

CKolkey commented Nov 14, 2023

Hey! I appreciate the kind words. No objection to the changes here, but check out lua/neogit/lib/hl.lua for the definition of the highlight groups. If you're going to add a group, it should get a definition/link there. :)

@gollth
Copy link
Contributor Author

gollth commented Nov 14, 2023

Sure thing, added the NeogitGraphAuthor group there

@CKolkey
Copy link
Member

CKolkey commented Nov 14, 2023

Good call reusing the highlight groups. Thanks!

@CKolkey CKolkey merged commit 06fd64e into NeogitOrg:master Nov 14, 2023
3 checks passed
@gollth gollth deleted the graph-colors branch November 15, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants