feat: add annotations for the Neogit config #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PriceHiller
force-pushed
the
feat/neogit-config-annotations
branch
from
db93246
to
e49cca3
Compare
PriceHiller
force-pushed
the
feat/neogit-config-annotations
branch
from
e49cca3
to
710bde3
Compare
|
Hot damn 🤩 Request a review when this is done ;) |
Since the last force push 710bde3 it should be good to go. |
|
Ok, now it is 100% ready to go. I can't find anything else. I was wrong previously, I'm nearly 100% confident now. Annoying that for annotations you can't really do any sort of tests or type checking. |
Also, I can't do this. I think only Collaborators or Members can directly request reviews, might be wrong though. |
Oops! Thats right. Alright, ignoring that detail... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #631
This adds annotations for the Neogit config and applies them for the
setupfunction.This makes it much easier to configure Neogit within Neovim for users of the Lua Language Server
See below for a quick demo:
neogit-annotation-demo.mp4