feat: CONTRIBUTING.md
#599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great start. I'd be happy to help expand on the architecture section, unless you want to. The only thing I'd add is more insistence on test coverage.. Thats already showing up as a weak spot with fixes breaking things... |
|
Yes, I'll add that section. What is the general concensus in markdown? Should proper nouns such as Neogit and Magit be put in Neogit or |
|
Hmm. I don't have a strong feeling on it. I like the backticks, as it makes it stand out nicely, but I'm pretty open to either. |
|
I think this should be a good enough starting point for the contributing guide, and over time we'll refine and add more sections to it when we find parts to be unintuitive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #581