fix: ensure floating popup windows are auto closed when they lose focus

[PriceHiller]

Prior to this commit any floating windows that lost focus were not closed and covered the editor as well as being inaccessible in that state.

This commit ensures the window is properly cleaned up when it loses focus. This only applies to floating windows.

See #591 for more details.

Closes #591

[CKolkey]

Cool! But the buffer's #create function can take an autocmds key, like

neogit/lua/neogit/buffers/commit_editor/init.lua

Line 42 in d5f2a96

autocmds = {

- I think this could probably take advantage of that, no?

[PriceHiller]

All of what was here previously were lies.

I was stuck back a few weeks on nightly 😔

[PriceHiller]

That should do it.
I'm creating all the options in a separate table first so I can conditionally create the winleave autocmd (as we only want it affecting floating windows) then calling Buffer.create against that table.

Only working in one of my terms, not all.

Resolved.