Fix trying to perform arithmetic on nil hunk_offset #1527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I got this locally. I'm not sure how I got there, but there I was: ``` ...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:18: The coroutine failed with this message: ....local/share/nvim/lazy/neogit/lua/neogit/lib/ui/init.lua:507: attempt to perform arithmetic on field 'hunk _offset' (a nil value) stack traceback: ^I[C]: in function 'error' ^I...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:18: in function 'callback_or_next' ^I...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:45: in function 'step' ^I...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:48: in function 'execute' ^I...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:118: in function 'callback' ^I...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:25: in function 'callback_or_next' ^I...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:45: in function 'saved_callback' ^I...are/nvim/lazy/plenary.nvim/lua/plenary/async/control.lua:126: in function 'tx' ^I.../share/nvim/lazy/plenary.nvim/lua/plenary/async/util.lua:71: in function 'callback' ^I...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:25: in function 'callback_or_next' ^I...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:45: in function 'cb' ^I...sto/.local/share/nvim/lazy/neogit/lua/neogit/process.lua:334: in function <...sto/.local/share/nvim/lazy/neogit/lua/neogit/process.lua:292> ``` See `attempt to perform arithmetic on field 'hunk _offset' (a nil value)`. This PR works around that by defaulting to `0` if there is no `hunk_offset`.
CKolkey
force-pushed
the
fnune/fix-hunk-offset-arithmetic
branch
from
de017e2
to
b2e226b
Compare
|
Well I'll be damned, just encountered this too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got this locally. I'm not sure how I got there, but there I was:
See
attempt to perform arithmetic on field 'hunk _offset' (a nil value). This PR works around that by defaulting to0if there is nohunk_offset.