Clean up *_mat_entry_set calls

[lgoettgens]

Use the already installed setindex! methods with @inbounds instead of ccalls everywhere

[lgoettgens]

for this function, I would like to make use of set! from #1908 (instead of the ccall).
The problem is that the set! implemented there needs to access parent of the first arg, so it does not work with pointers there. What do you think about adding a third argument to set! that defaults to parent(first_arg) (for non-pointers), but in this particular case we can just pass base_ring(a)

Just to point this out, this won't happen in this PR.

[fingolfin]

yeah, makes sense. Should the parent be a thread argument, though, or maybe a kwarg (that would make it easier to grep, harder to get confused about?)

[lgoettgens]

what do you mean by thread argument?

And the way that I understand how kwargs work in julia, a call always involves a NamedTuple construction and another call (to the kwcall) function. This may have an overhead that we do not want to have in something low-level as setindex!.

[thofma]

I vote for making it a normal positional argument.

[fingolfin]

sorry, typo/braino, I meant "third argument"

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.38%. Comparing base (633112d) to head (46babf0).
Report is 11 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1910      +/-   ##
==========================================
+ Coverage   87.24%   87.38%   +0.14%     
==========================================
  Files          97       97              
  Lines       35590    35491      -99     
==========================================
- Hits        31049    31014      -35     
+ Misses       4541     4477      -64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lgoettgens]

I only added Base.require_one_based_indexing to all places without a _check_dim call. For the majority, Nemocas/AbstractAlgebra.jl#1879 will take care of that.