-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 1.5.2 - Sorted Files - Thread settings #3
Open
JesperJurcenoks
wants to merge
38
commits into
NeighborhoodGuard:master
Choose a base branch
from
JesperJurcenoks:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major changes: - Moved thread settings to localsettings - Sorted the files alphabetically(chronologically) before upload for nice progression of upload when internet has been down. Minor Edits. Stronger defaults that better matches normal use Updated Copyright Year Fixed Typo in author Name Added a few comments around settings.
Inspired by Howard Matis: - created var baselocation and based other directories below the base location - moved 2 times to localsettings - moved a few sections around Added Flag for using sftp instead of ftp.
- Added comments on different kinds of imports. - It was unclear fromv the code which variables were local which came from localsettings, to change all references to variables from localsettings to explicit path so that they could be easily identified.
- Changed hardcoded sleep timers from hardcoded values to configurable values from localsettings - added a bit of logging - removed 1 line of commented out old code - removed incorrect reverence to a global variable
- changed all function names from "ftp" to "server" to become agnostic for when we allow connection using both ftp and sftp - changed all internal variable names from "ftp" to 'server" to become agnostic for when we allow connection using both ftp and sftp - left localsettings config variables unchanged to remain at least somewhat backwards compatible.
FTP and SFTP on Dreamhost sees absolute paths differently.
- Changed version to 1.6.0 - in the few functions where FTP calls where made: add a branch to call SFTP when needed instead. - Added a lot of Debug messaged to find out in which function the code crashes - Could not distinguish ftp_uploads debug messages in the chatter from SFTP debugs, had to add prefix to every debug message.
Ensured that FTP cannot still be used without installing the pysftp library.
For 32GB SD cards retaining 6 days is just too much.
- missed on config variable, when moving all to full path.
Added comments to clarify minimum settings to change upon installation
Added Help moved main loop away from main and to its own function called from main.
Initial version of short function that retrieves a few status items and prints them.
moved the ftp upload part out of storefile and into putfile
ftp_upload now uploads Heartbeat status to cloud-server
Added additional information to the heartbeat status.
Error occurred when status dir did not exist.
Fixed typo again!
- Status now reports filesize of both SD card and Harddisk on Raspberry Pi systems - ftp_upload logfile is now stored under base_location - added a debug error message
No need to change ftp destination when switching between ftp and sftp
Handles a separate Partition for /tmp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes:
nice progression of upload when internet has been down.
Minor Edits.
Stronger defaults that better matches normal use
Updated Copyright Year
Fixed Typo in author Name
Added a few comments around settings.