Apply suggestions from code review

Co-authored-by: Chris Yeninas <[email protected]>
NebulaModTeam · Mar 10, 2024 · 4185b63 · 4185b63
1 parent 44df59a
commit 4185b63
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/NebulaWorld/Player/GizmoManager.cs b/NebulaWorld/Player/GizmoManager.cs
@@ -75,8 +75,10 @@ public void OnUpdate()
 
     private static void GetMapPing()
     {
-        // Modify from UIGlobemap.TeleportLogic
-        if (Camera.main == null || GameMain.localPlanet == null) return;
+		// Modify from UIGlobemap.TeleportLogic
+        var mainCam = Camera.main;
+        if (mainCam == null || GameMain.localPlanet == null) return;
+        if (!Physics.Raycast(mainCam.ScreenPointToRay(Input.mousePosition), out var hitInfo, 800f, 8720, QueryTriggerInteraction.Collide)) return;
         if (!Physics.Raycast(Camera.main.ScreenPointToRay(Input.mousePosition), out var hitInfo, 800f, 8720, QueryTriggerInteraction.Collide)) return;
 
         var starmap = UIRoot.instance.uiGame.starmap;
@@ -128,7 +130,7 @@ private static void GetMapPing()
     private void UpdateIndicator()
     {
         if (GameMain.mainPlayer.gizmo.naviIndicatorGizmo != null
-            && naviIndicatorGizmo != null) // When main player is navigating to other target, close the exisitng one
+            && naviIndicatorGizmo != null) // When main player is navigating to other target, close the existing one
         {
             indicatorPlayerId = 0;
             indicatorPlanetId = 0;
@@ -159,7 +161,7 @@ private void UpdateIndicator()
             return;
         }
 
-        // Close gizmos if there is no vaild target
+        // Close gizmos if there is no valid target
         indicatorPlayerId = 0;
         indicatorPlanetId = 0;
         if (naviIndicatorGizmoStarmap != null)