PostMount Env Variables (e.g. NUM_OSTS) #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no way to get the number of OSTs, etc when using `PostMount`
commands. For instance, when setting the striping.
This change adds the following environment variables for use in the
`NnfStorageProfiles` when using `*CmdLines`:
- NUM_MDTS
- NUM_MGTS
- NUM_MGTMDTS
- NUM_OSTS
- NUM_NNFNODES
To support this, a list of nodes for each component type has been added
to the status of `NnfStorage`, which in turn is copied to the
`NnfNodeStorage` resource's spec. This info can then be turned into the
environment variables for use when running the commands.
The `.nnf-servers.json` file created to store this information on the
compute node has been updated to this new structure.
An example with 8 OSTs and 2 MGTMDTs on 1 rabbit:
```json
{
"mdt": [],
"mgt": [],
"mgtmdt": [
"rabbit-node-1",
"rabbit-node-1"
],
"nnfNode": [
"rabbit-node-1"
],
"ost": [
"rabbit-node-1",
"rabbit-node-1",
"rabbit-node-1",
"rabbit-node-1",
"rabbit-node-1",
"rabbit-node-1",
"rabbit-node-1",
"rabbit-node-1"
]
}
```
Signed-off-by: Blake Devcich <[email protected]>
roehrich-hpe
approved these changes
Dec 5, 2024
| // EDIT THIS FUNCTION! If the annotation is holding anything that is | ||
| // hub-specific then copy it into 'dst' from 'restored'. | ||
| // Otherwise, you may comment out UnmarshalData() until it's needed. | ||
| if hasAnno { | ||
| dst.Status.LustreComponents.MDTs = append([]string(nil), restored.Status.LustreComponents.MDTs...) |
There was a problem hiding this comment.
I would not have expected (x) to work for initializing that string array. I would have expected {x} instead, but that doesn't work. Huh.
I wonder what that's called.
There was a problem hiding this comment.
Yea, this one really threw me for a loop.
matthew-richerson
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no way to get the number of OSTs, etc when using
PostMountcommands. For instance, when setting the striping.This change adds the following environment variables for use in the
NnfStorageProfileswhen using*CmdLines:To support this, a list of nodes for each component type has been added to the status of
NnfStorage, which in turn is copied to theNnfNodeStorageresource's spec. This info can then be turned into the environment variables for use when running the commands.The
.nnf-servers.jsonfile created to store this information on the compute node has been updated to this new structure.An example with 8 OSTs and 2 MGTMDTs on 1 rabbit:
{ "mdt": [], "mgt": [], "mgtmdt": [ "rabbit-node-1", "rabbit-node-1" ], "nnfNode": [ "rabbit-node-1" ], "ost": [ "rabbit-node-1", "rabbit-node-1", "rabbit-node-1", "rabbit-node-1", "rabbit-node-1", "rabbit-node-1", "rabbit-node-1", "rabbit-node-1" ] }