Check Data Movement Manager for Ready Flag for DataIn/DataOut #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add check in DataIn/DataOut and requeue when DMM is not ready - Remove omitempty from ddm ready flag so this shows up as false when not ready. - RBAC fix Signed-off-by: Blake Devcich <[email protected]>
bdevcich
requested review from
ajfloeder,
matthew-richerson and
roehrich-hpe
Signed-off-by: Blake Devcich <[email protected]>
roehrich-hpe
approved these changes
Nov 14, 2023
Signed-off-by: Blake Devcich <[email protected]>
ajfloeder
approved these changes
Nov 14, 2023
| return nil, dwsv1alpha2.NewResourceError("could not get NnfDataMovementManager %v", client.ObjectKeyFromObject(dmm)).WithError(err).WithUserMessage("could not determine data movement readiness") | ||
| } | ||
| if !dmm.Status.Ready { | ||
| return Requeue("pending data movement readiness").withObject(dmm), nil |
There was a problem hiding this comment.
I think this would be better requeuing after a time delay
.after(5 * time.Second)
Signed-off-by: Blake Devcich <[email protected]>
matthew-richerson
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ready.
Signed-off-by: Blake Devcich [email protected]