Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added user mpirun hostfile slots to NnfDataMovement #225

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Added user mpirun hostfile slots to NnfDataMovement #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions api/v1alpha1/nnf_datamovement_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,14 @@ type NnfDataMovementConfig struct {
// Note: Enabling this option may degrade performance.
// +kubebuilder:default:=false
StoreStdout bool `json:"storeStdout,omitempty"`

// The number of slots specified in the MPI hostfile. A value of 0 disables the use of slots in
// the hostfile. Nil will defer to the value specified in the nnf-dm-config ConfigMap.
Slots *int `json:"slots,omitempty"`

// The number of max_slots specified in the MPI hostfile. A value of 0 disables the use of slots
// in the hostfile. Nil will defer to the value specified in the nnf-dm-config ConfigMap.
MaxSlots *int `json:"maxSlots,omitempty"`
}

// DataMovementCommandStatus defines the observed status of the underlying data movement
Expand Down
12 changes: 11 additions & 1 deletion api/v1alpha1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions config/crd/bases/nnf.cray.hpe.com_nnfdatamovements.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,16 @@ spec:
the output is always logged. Note: Enabling this option may
degrade performance.'
type: boolean
maxSlots:
description: The number of max_slots specified in the MPI hostfile.
A value of 0 disables the use of slots in the hostfile. Nil
will defer to the value specified in the nnf-dm-config ConfigMap.
type: integer
slots:
description: The number of slots specified in the MPI hostfile.
A value of 0 disables the use of slots in the hostfile. Nil
will defer to the value specified in the nnf-dm-config ConfigMap.
type: integer
storeStdout:
default: false
description: 'Similar to LogStdout, store the command''s stdout
Expand Down
Loading