feat(contracts-eth): don't allow zero-address initialization in AdminControlled
#866
+18
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #844
Note: -
Instead of adding a new
require(_admin != address(0)
(and copying the comment to describe why) I used existingverifyAdminAddress()
to reduce redundancy but the existing method name and require error message might not be appropriate. Also, the fact thatnewAdmin != admin
will hit first rather than zero address check.