Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdminControlled: don't allow zero-address initialization #844

Open
sept-en opened this issue Nov 7, 2022 · 0 comments · May be fixed by #866
Open

AdminControlled: don't allow zero-address initialization #844

sept-en opened this issue Nov 7, 2022 · 0 comments · May be fixed by #866

Comments

@sept-en
Copy link
Contributor

sept-en commented Nov 7, 2022

In PR#705, new functionality to nominate and accept admin was added. One of that parts was verifying that a zero address value for admin is not allowed for security measures. However, by default, the constructor allows initialization with zero address admin. This should be changed and disallowed. In case it's the expected behavior to have no admin, the deployer should use some other address (e.g., with all "1" digits).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant