-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make view methods pausable #144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There're small nitpicks like args.roles.len() == 0
-> !args.is_empty()
or let err = format!("{}", err);
-> let err = err.to_string();
, but they're not that important, so can be ignored
.pausable_contract | ||
.pa_pause_feature(&setup.pause_manager, "get_counter") | ||
.await?; | ||
assert_success_with(res, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also call the get_counter
as a view method to ensure that we are able to do so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already do a view call line below
near-sdk
version to avoid auto upgrade that breaks CI and build due to dependencies conflicts.