Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing field in customer attributes #23

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

a-spn
Copy link
Contributor

@a-spn a-spn commented Mar 14, 2024

Adding the field 'urls' in CustomerAttributes, according to the official documentation.

https://docs.lemonsqueezy.com/api/customers#the-customer-object

Json screen

Mapping this field into a "map[string]string" seemed to me to be the best option (shorter and more readable + only one field in the sub-object for the moment). If it's preferable, I can create another structure to parse the field "urls" returned by the lemonsqueezy API.

customer.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.04%. Comparing base (9a405ae) to head (d60022c).

❗ Current head d60022c differs from pull request most recent head 5ff4fd4. Consider uploading reports for the commit 5ff4fd4 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #23   +/-   ##
=======================================
  Coverage   81.04%   81.04%           
=======================================
  Files          23       23           
  Lines         575      575           
=======================================
  Hits          466      466           
  Misses         56       56           
  Partials       53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@a-spn a-spn force-pushed the add-missing-customer-attribute branch from d60022c to 5ff4fd4 Compare March 14, 2024 12:35
@a-spn
Copy link
Contributor Author

a-spn commented Mar 14, 2024

Thank you for your feedback, I replaced the field with an inline struct.

@a-spn a-spn requested a review from AchoArnold March 14, 2024 12:41
@AchoArnold AchoArnold merged commit 81f23ab into NdoleStudio:main Mar 14, 2024
2 checks passed
@AchoArnold
Copy link
Member

Thanks @a-spn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants