Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Docker testAll.sh Script #2640

Open
wants to merge 5 commits into
base: integration
Choose a base branch
from

Conversation

foster33
Copy link
Collaborator

@foster33 foster33 commented Nov 19, 2024

This PR aims to improve docker/scripts/testAll.sh

Before this change, the script had a few issues:

  • If a test failed a configurable number of times, it would not let the other tests run.
  • There were timeouts that caused the script to run longer than necessary.
  • Test result outputs could be hard to understand when multiple attempts occurred.

This PR adds:

  • Improved formatting of individual test results.
  • Information about the amount of time each test takes.
  • An overall test summary that shows the passing and failed tests.
  • Allows all tests to run no matter the status of other tests.
  • Removes unnecessary timeout after all 3 attempts already failed.
  • An option to skip the cleanup stage, keeping all logs from tests ( -noCleanup )
  • Adds more descriptive fail messages that give expected number of events / files.

I tried to improve this script to look like the output from datawaveWebTest, which I found to be quite nice.

@foster33
Copy link
Collaborator Author

foster33 commented Nov 19, 2024

Here is an example of the testAll.sh output before the change:
The script ends after this failure and does not let the other tests run.
image

Here are some images of the testAll.sh output after the change:
Passing & failing tests:
image
Summary (not related to test results above):
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants