Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid re-normalizing unfielded lookup results #2218

Open
wants to merge 21 commits into
base: integration
Choose a base branch
from
Open

Avoid re-normalizing unfielded lookup results #2218

wants to merge 21 commits into from

Conversation

foster33
Copy link
Collaborator

@foster33 foster33 commented Jan 16, 2024 •
edited
Loading

This PR closes #877

  • Adds a configurable cache that will prevent a field / term pair, that's actual value was already found in the index, from being re-normalized (if only one normalizer is being used).
  • Adds a test for the cache

@foster33 foster33 changed the title WIP - Issue 877: Avoid normalizing unfielded lookup results Avoid re-normalizing unfielded lookup results Apr 4, 2024
@foster33
Copy link
Collaborator Author

foster33 commented Apr 4, 2024 •
edited
Loading

I think additional tests should be added to ensure we are covering more cases... But I have removed the WIP and this is now ready for review.

@foster33 foster33 mentioned this pull request Apr 26, 2024
Closed
@foster33 foster33 added the linked label May 7, 2024
@foster33 foster33 requested a review from jwomeara as a code owner August 2, 2024 13:09
@foster33 foster33 marked this pull request as draft August 2, 2024 13:11
@foster33 foster33 marked this pull request as ready for review August 2, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivakegg ivakegg ivakegg requested changes

@jwomeara jwomeara Awaiting requested review from jwomeara

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
linked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid normalizing unfielded lookup results
3 participants
@foster33 @ivakegg @KhakiField