Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary method from ingesthelper and clean test pt2 #2116

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

austin007008
Copy link
Collaborator

No description provided.

@MiguelRicardos
Copy link
Collaborator

Looks good to me, please squash to 1 commit.

git checkout integration
git pull
git checkout feature-clean-test-pt2
git rebase -i integration
<squash down>
git push -f

Copy link
Collaborator

@apmoriarty apmoriarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apmoriarty
Copy link
Collaborator

Looks good to me, please squash to 1 commit.

git checkout integration
git pull
git checkout feature-clean-test-pt2
git rebase -i integration
<squash down>
git push -f

The second commit is from updating the branch in the UI. In reality there is only one 'real' commit -- no cause for concern.

@austin007008 austin007008 merged commit 5d1edc1 into integration Oct 5, 2023
3 checks passed
@austin007008 austin007008 deleted the feature-clean-test-pt2 branch October 5, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration Tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants