Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1438 - optionally gather fields after ingest exception #1439

Open
wants to merge 30 commits into
base: integration
Choose a base branch
from

Conversation

matthpeterson
Copy link
Collaborator

No description provided.

@matthpeterson
Copy link
Collaborator Author

matthpeterson commented Mar 4, 2022

Multiple test cases were conducted using the quickstart json data:

  1. EVENT_DATE_MISSING added in JsonReader to every other record.
  2. getFields in JsonIngestHelper was made to throw an exception. JsonIngestHelper was also modified to implement SalvagedFields with a hardcoded multimap of mocked salvaged fields.
    Note both of the two test cases were done with throw-away code changes, made only for testing this PR.
  3. Regression case (no modifications, no errors)

Case 1 operated as it does today, including all the normally-ingested fields and the supplemental fields in the error table writes. The other half of the data was written to the shard table, as expected.

Case 2 operated with the new behavior: adding LOAD_DATE, ORIG_FILE, and salvaged fields to the error tables along with what it previously written.

Case 3 operated as expected, ingesting the data into the shard table.

ivakegg
ivakegg previously approved these changes Mar 16, 2022
dtspence
dtspence previously approved these changes Mar 18, 2022
hlgp
hlgp previously approved these changes May 6, 2022
@hgklohr hgklohr dismissed stale reviews from hlgp, dtspence, and ivakegg via 3a4f54b June 9, 2023 13:35
@mineralntl mineralntl self-assigned this Nov 18, 2024
@mineralntl mineralntl removed their assignment Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants