Skip to content

Commit

Permalink
Merge branch 'integration' into task/RemoveUniversalset-1699
Browse files Browse the repository at this point in the history
  • Loading branch information
mineralntl authored Oct 5, 2023
2 parents 50bf1d5 + 5d1edc1 commit aa34288
Show file tree
Hide file tree
Showing 59 changed files with 214 additions and 210 deletions.
2 changes: 1 addition & 1 deletion common-test/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>gov.nsa.datawave</groupId>
<artifactId>datawave-parent</artifactId>
<version>5.11.0-SNAPSHOT</version>
<version>5.12.0-SNAPSHOT</version>
</parent>
<artifactId>datawave-common-test</artifactId>
<name>${project.artifactId}</name>
Expand Down
2 changes: 1 addition & 1 deletion docs/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>gov.nsa.datawave</groupId>
<artifactId>datawave-parent</artifactId>
<version>5.11.0-SNAPSHOT</version>
<version>5.12.0-SNAPSHOT</version>
</parent>
<artifactId>datawave-docs</artifactId>
<!-- Declare all datawave modules as dependencies in order to have the javadoc include all the datawave source. -->
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>gov.nsa.datawave</groupId>
<artifactId>datawave-parent</artifactId>
<version>5.11.0-SNAPSHOT</version>
<version>5.12.0-SNAPSHOT</version>
<packaging>pom</packaging>
<name>DataWave</name>
<description>DataWave is a Java-based ingest and query framework that leverages Apache Accumulo to provide fast,
Expand Down
2 changes: 1 addition & 1 deletion warehouse/accumulo-extensions/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>gov.nsa.datawave</groupId>
<artifactId>datawave-warehouse-parent</artifactId>
<version>5.11.0-SNAPSHOT</version>
<version>5.12.0-SNAPSHOT</version>
</parent>
<artifactId>datawave-accumulo-extensions</artifactId>
<name>${project.artifactId}</name>
Expand Down
2 changes: 1 addition & 1 deletion warehouse/assemble/datawave/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>gov.nsa.datawave</groupId>
<artifactId>assemble-parent</artifactId>
<version>5.11.0-SNAPSHOT</version>
<version>5.12.0-SNAPSHOT</version>
</parent>
<artifactId>assemble-datawave</artifactId>
<packaging>pom</packaging>
Expand Down
2 changes: 1 addition & 1 deletion warehouse/assemble/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>gov.nsa.datawave</groupId>
<artifactId>datawave-warehouse-parent</artifactId>
<version>5.11.0-SNAPSHOT</version>
<version>5.12.0-SNAPSHOT</version>
</parent>
<artifactId>assemble-parent</artifactId>
<packaging>pom</packaging>
Expand Down
2 changes: 1 addition & 1 deletion warehouse/assemble/webservice/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>gov.nsa.datawave</groupId>
<artifactId>assemble-parent</artifactId>
<version>5.11.0-SNAPSHOT</version>
<version>5.12.0-SNAPSHOT</version>
</parent>
<artifactId>assemble-webservice</artifactId>
<name>${project.artifactId}</name>
Expand Down
2 changes: 1 addition & 1 deletion warehouse/common/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>gov.nsa.datawave</groupId>
<artifactId>datawave-warehouse-parent</artifactId>
<version>5.11.0-SNAPSHOT</version>
<version>5.12.0-SNAPSHOT</version>
</parent>
<artifactId>datawave-common</artifactId>
<name>${project.artifactId}</name>
Expand Down
2 changes: 1 addition & 1 deletion warehouse/core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>gov.nsa.datawave</groupId>
<artifactId>datawave-warehouse-parent</artifactId>
<version>5.11.0-SNAPSHOT</version>
<version>5.12.0-SNAPSHOT</version>
</parent>
<artifactId>datawave-core</artifactId>
<packaging>jar</packaging>
Expand Down
2 changes: 1 addition & 1 deletion warehouse/data-dictionary-core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>gov.nsa.datawave</groupId>
<artifactId>datawave-warehouse-parent</artifactId>
<version>5.11.0-SNAPSHOT</version>
<version>5.12.0-SNAPSHOT</version>
</parent>
<artifactId>datawave-data-dictionary-core</artifactId>
<packaging>jar</packaging>
Expand Down
2 changes: 1 addition & 1 deletion warehouse/edge-dictionary-core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>gov.nsa.datawave</groupId>
<artifactId>datawave-warehouse-parent</artifactId>
<version>5.11.0-SNAPSHOT</version>
<version>5.12.0-SNAPSHOT</version>
</parent>
<artifactId>datawave-edge-dictionary-core</artifactId>
<packaging>jar</packaging>
Expand Down
2 changes: 1 addition & 1 deletion warehouse/edge-model-configuration-core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>gov.nsa.datawave</groupId>
<artifactId>datawave-warehouse-parent</artifactId>
<version>5.11.0-SNAPSHOT</version>
<version>5.12.0-SNAPSHOT</version>
</parent>
<artifactId>datawave-edge-model-configuration-core</artifactId>
<packaging>jar</packaging>
Expand Down
2 changes: 1 addition & 1 deletion warehouse/index-stats/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>gov.nsa.datawave</groupId>
<artifactId>datawave-warehouse-parent</artifactId>
<version>5.11.0-SNAPSHOT</version>
<version>5.12.0-SNAPSHOT</version>
</parent>
<artifactId>datawave-index-stats</artifactId>
<packaging>jar</packaging>
Expand Down
2 changes: 1 addition & 1 deletion warehouse/ingest-configuration/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>gov.nsa.datawave</groupId>
<artifactId>datawave-warehouse-parent</artifactId>
<version>5.11.0-SNAPSHOT</version>
<version>5.12.0-SNAPSHOT</version>
</parent>
<artifactId>datawave-ingest-configuration</artifactId>
<dependencies>
Expand Down
2 changes: 1 addition & 1 deletion warehouse/ingest-core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>gov.nsa.datawave</groupId>
<artifactId>datawave-warehouse-parent</artifactId>
<version>5.11.0-SNAPSHOT</version>
<version>5.12.0-SNAPSHOT</version>
</parent>
<artifactId>datawave-ingest-core</artifactId>
<packaging>jar</packaging>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,11 @@
import java.util.Collection;
import java.util.HashSet;
import java.util.Set;
import java.util.regex.Pattern;

import org.apache.hadoop.conf.Configuration;
import org.apache.log4j.Logger;

import com.google.common.annotations.VisibleForTesting;
import com.google.common.collect.Sets;

import datawave.ingest.data.config.FieldConfigHelper;

Expand Down Expand Up @@ -69,7 +67,7 @@ private static Collection<String> trimConfigStrings(Configuration config, String
String[] names = datawave.util.StringUtils.split(c, ',');
for (String n : names) {
n = n.trim();
if (n.equals(""))
if (n.isEmpty())
continue;

s.add(n);
Expand Down Expand Up @@ -179,25 +177,4 @@ public String getRawDocumentViewName() {
return rawDocumentViewName;
}

public static Set<String> parseMultiLineConfigValue(String s, Pattern splitter) {
return cleanSet(Sets.newHashSet(splitter.split(s)));
}

/**
* Utility method to take a {@code String[]} and return a {@code Set<String>} where the values are trimmed
*
* @param items
* String[] of items to trim and turn into a set
* @return unique Set of strings where whitespace has been trimmed.
*/
public static Set<String> cleanSet(Collection<String> items) {
Set<String> itemSet = new HashSet<>();
for (String item : items) {
item = item.trim();
if (!item.isEmpty()) {
itemSet.add(item);
}
}
return itemSet;
}
}
2 changes: 1 addition & 1 deletion warehouse/ingest-csv/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>gov.nsa.datawave</groupId>
<artifactId>datawave-warehouse-parent</artifactId>
<version>5.11.0-SNAPSHOT</version>
<version>5.12.0-SNAPSHOT</version>
</parent>
<artifactId>datawave-ingest-csv</artifactId>
<packaging>jar</packaging>
Expand Down
2 changes: 1 addition & 1 deletion warehouse/ingest-json/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>gov.nsa.datawave</groupId>
<artifactId>datawave-warehouse-parent</artifactId>
<version>5.11.0-SNAPSHOT</version>
<version>5.12.0-SNAPSHOT</version>
</parent>
<artifactId>datawave-ingest-json</artifactId>
<packaging>jar</packaging>
Expand Down
2 changes: 1 addition & 1 deletion warehouse/ingest-nyctlc/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>gov.nsa.datawave</groupId>
<artifactId>datawave-warehouse-parent</artifactId>
<version>5.11.0-SNAPSHOT</version>
<version>5.12.0-SNAPSHOT</version>
</parent>
<artifactId>datawave-ingest-nyctlc</artifactId>
<packaging>jar</packaging>
Expand Down
2 changes: 1 addition & 1 deletion warehouse/ingest-scripts/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>gov.nsa.datawave</groupId>
<artifactId>datawave-warehouse-parent</artifactId>
<version>5.11.0-SNAPSHOT</version>
<version>5.12.0-SNAPSHOT</version>
</parent>
<artifactId>datawave-ingest-scripts</artifactId>
<name>${project.artifactId}</name>
Expand Down
2 changes: 1 addition & 1 deletion warehouse/ingest-wikipedia/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>gov.nsa.datawave</groupId>
<artifactId>datawave-warehouse-parent</artifactId>
<version>5.11.0-SNAPSHOT</version>
<version>5.12.0-SNAPSHOT</version>
</parent>
<artifactId>datawave-ingest-wikipedia</artifactId>
<packaging>jar</packaging>
Expand Down
2 changes: 1 addition & 1 deletion warehouse/metrics-core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>gov.nsa.datawave</groupId>
<artifactId>datawave-warehouse-parent</artifactId>
<version>5.11.0-SNAPSHOT</version>
<version>5.12.0-SNAPSHOT</version>
</parent>
<artifactId>datawave-metrics-core</artifactId>
<packaging>jar</packaging>
Expand Down
2 changes: 1 addition & 1 deletion warehouse/ops-tools/config-compare/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>gov.nsa.datawave</groupId>
<artifactId>datawave-ops-tools-parent</artifactId>
<version>5.11.0-SNAPSHOT</version>
<version>5.12.0-SNAPSHOT</version>
</parent>
<artifactId>datawave-ops-tools-config-compare</artifactId>
<dependencies>
Expand Down
2 changes: 1 addition & 1 deletion warehouse/ops-tools/index-validation/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>gov.nsa.datawave</groupId>
<artifactId>datawave-ops-tools-parent</artifactId>
<version>5.11.0-SNAPSHOT</version>
<version>5.12.0-SNAPSHOT</version>
</parent>
<artifactId>datawave-ops-tools-index-validation</artifactId>
<packaging>jar</packaging>
Expand Down
2 changes: 1 addition & 1 deletion warehouse/ops-tools/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>gov.nsa.datawave</groupId>
<artifactId>datawave-warehouse-parent</artifactId>
<version>5.11.0-SNAPSHOT</version>
<version>5.12.0-SNAPSHOT</version>
</parent>
<artifactId>datawave-ops-tools-parent</artifactId>
<packaging>pom</packaging>
Expand Down
2 changes: 1 addition & 1 deletion warehouse/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>gov.nsa.datawave</groupId>
<artifactId>datawave-parent</artifactId>
<version>5.11.0-SNAPSHOT</version>
<version>5.12.0-SNAPSHOT</version>
</parent>
<artifactId>datawave-warehouse-parent</artifactId>
<packaging>pom</packaging>
Expand Down
2 changes: 1 addition & 1 deletion warehouse/query-core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>gov.nsa.datawave</groupId>
<artifactId>datawave-warehouse-parent</artifactId>
<version>5.11.0-SNAPSHOT</version>
<version>5.12.0-SNAPSHOT</version>
</parent>
<artifactId>datawave-query-core</artifactId>
<packaging>jar</packaging>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,34 +89,34 @@ public void testIteratorStackSetup() throws Exception {

// Top of the stack is a ConfigurableVisibilityFilter (which creates a VisibilityFilter as its source) with auths C1,C2,C3
assertEquals(ConfigurableVisibilityFilter.class, internalIter.getClass());
cvf = ConfigurableVisibilityFilter.class.cast(internalIter);
cvf = (ConfigurableVisibilityFilter) internalIter;
source = Whitebox.getInternalState(cvf, "source");
assertEquals(VisibilityFilter.class, source.getClass());
vf = VisibilityFilter.class.cast(source);
vf = (VisibilityFilter) source;
actualAuths = new TreeSet<>(Arrays.asList(Whitebox.getInternalState(vf, Authorizations.class).toString().split(",")));
assertEquals(new TreeSet<>(Arrays.asList("C1", "C2", "C3")), actualAuths);
source = Whitebox.getInternalState(vf, "source");

// Next on the stack is a ConfigurableVisibilityFilter (which creates a VisibilityFilter as its source) with auths B1,B2,B3
assertEquals(ConfigurableVisibilityFilter.class, source.getClass());
cvf = ConfigurableVisibilityFilter.class.cast(source);
cvf = (ConfigurableVisibilityFilter) source;
source = Whitebox.getInternalState(cvf, "source");
assertEquals(VisibilityFilter.class, source.getClass());
vf = VisibilityFilter.class.cast(source);
vf = (VisibilityFilter) source;
actualAuths = new TreeSet<>(Arrays.asList(Whitebox.getInternalState(vf, Authorizations.class).toString().split(",")));
assertEquals(new TreeSet<>(Arrays.asList("B1", "B2", "B3")), actualAuths);
source = Whitebox.getInternalState(vf, "source");

// The next table iterator should be the standard VisibilityFilter which will have auths A1,A2,A3
assertEquals(VisibilityFilter.class, source.getClass());
vf = VisibilityFilter.class.cast(source);
vf = (VisibilityFilter) source;
actualAuths = new TreeSet<>(Arrays.asList(Whitebox.getInternalState(vf, Authorizations.class).toString().split(",")));
assertEquals(new TreeSet<>(Arrays.asList("A1", "A2", "A3")), actualAuths);
source = Whitebox.getInternalState(vf, "source");

// The next table iterator should be a DeletingIterator
assertEquals(DeletingIterator.class, source.getClass());
DeletingIterator di = DeletingIterator.class.cast(source);
DeletingIterator di = (DeletingIterator) source;
source = Whitebox.getInternalState(di, "source");

// And finally, at the bottom of the stack is a MultiIterator (which has no source field)
Expand Down
Loading

0 comments on commit aa34288

Please sign in to comment.