Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more descriptive types to the data dictionary #31

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

foster33
Copy link
Collaborator

This PR closes NationalSecurityAgency/datawave#708

Depends on NationalSecurityAgency/datawave-type-utils#34

The data dictionary page previously showed "Unknown" for data types that were not in its list of datatypes.

This PR adds:

  • Use of a class defined data dictionary description for 'Types'
  • Adds some new test cases

See #23 for more background information and discussion about these changes.
This is the same as #23 . It was accidentally closed when I deleted my fork.

@dws4
Copy link
Collaborator

dws4 commented Jul 22, 2024

I am not sure if this ticket is related or if there is another ticket to this issue, but there also seems to be weird lastUpdated entries where the dates contain a '+' value. It seems like they are newly added.

@foster33
Copy link
Collaborator Author

I am not sure if this ticket is related or if there is another ticket to this issue, but there also seems to be weird lastUpdated entries where the dates contain a '+' value. It seems like they are newly added.

It does not seem like the changes in this PR are causing that. I do see what you mean. I tested to see if it would happen with the latest changes with "main" and still get the occasional timestamp with "+". It seems to only affect fields that include _TOKEN. Trying to debug this now. But I will open an issue about this in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unmapped datatypes show as Unknown in data dictionary
2 participants