Link and search for element FCs #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
aanil
commented
Nov 12, 2024
aanil
commented
- Link element FCs correctly in bioinfo tab page
- Add element FCs to searchso that they can be found more easily
alneberg
reviewed
Nov 13, 2024
| "name": row_key, | ||
| } | ||
| flowcells.append(fc) | ||
| except AttributeError: |
There was a problem hiding this comment.
What attribute error is it that we're catching? The row_key.lower? I see that it's the same for all the other instrument types so mostly curious if you know?
There was a problem hiding this comment.
I'm not sure about the original reason. The original code looped through the view result directly and called row.key.lower(). Maybe when row.key was None it would throw an Attribute error? We could probably get rid of the try-except now that we do it differently.
There was a problem hiding this comment.
That makes sense. If you're keen on removing it go for it, but you don't have to for this PR.
There was a problem hiding this comment.
I'll leave it in place for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.