Fix extra postfix in sample names for BCL Convert #440
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #440 +/- ##
==========================================
- Coverage 29.05% 29.00% -0.05%
==========================================
Files 31 31
Lines 4898 4906 +8
==========================================
Hits 1423 1423
- Misses 3475 3483 +8 ☔ View full report in Codecov by Sentry. |
taca/illumina/Runs.py
Outdated
| # Remove the trailing "_SX" postfix from samples names for BCL Convert when it handles SmartSeq3 libraries | ||
| for entry in html_report_laneBarcode_parser.sample_data: | ||
| if "_S" in entry["Sample"]: | ||
| entry["Sample"] = "_".join(entry["Sample"].split("_")[:2]) |
There was a problem hiding this comment.
If we are removing only the last element wouldn't "_".join(entry["Sample"].split("_")[:-1]) be better?
There was a problem hiding this comment.
"".join(entry["Sample"].split("")[:-1])
Fixed
taca/illumina/Runs.py
Outdated
| html_report_laneBarcode_parser.sample_data, | ||
| key=lambda k: (k["Lane"].lower(), k["Sample"]), | ||
| ) | ||
| _generate_lane_html( |
There was a problem hiding this comment.
I'm not entirely sure how this works, but are we overwriting the file that exists at dest_html_report_laneBarcode here?
There was a problem hiding this comment.
Or is it the same file here since we symlink it os.symlink(source, dest)?
There was a problem hiding this comment.
Yes, we are overwriting the file. Otherwise we will have to create hard links of all files under source to dest individually, in which case the scripts will be much more complicated...
chuan-wang
merged commit 4bd531a
into
NationalGenomicsInfrastructure:master
Validation 24_20.