ui: PrettyPrint component uses now prettier 3.1 #3662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhenkens
force-pushed
the
feature/prettier3
branch
3 times, most recently
from
7f1156e to
dea3dd4
Compare
SuperITMan
changed the title
SuperITMan
changed the title
mhenkens
force-pushed
the
feature/prettier3
branch
4 times, most recently
from
aded19c to
8b3265e
Compare
mhenkens
force-pushed
the
feature/prettier3
branch
from
8b3265e to
71e3956
Compare
SuperITMan
requested changes
Dec 21, 2023
packages/stark-ui/src/modules/pretty-print/components/pretty-print.component.ts
Outdated
Show resolved
Hide resolved
packages/stark-ui/src/modules/pretty-print/components/pretty-print.component.ts
Outdated
Show resolved
Hide resolved
packages/stark-ui/src/modules/pretty-print/components/pretty-print.component.ts
Outdated
Show resolved
Hide resolved
packages/stark-ui/src/modules/pretty-print/services/pretty-print.service.ts
Outdated
Show resolved
Hide resolved
packages/stark-ui/src/modules/pretty-print/services/pretty-print.service.intf.ts
Outdated
Show resolved
Hide resolved
packages/stark-ui/src/modules/pretty-print/services/pretty-print.service.ts
Outdated
Show resolved
Hide resolved
packages/stark-ui/src/modules/pretty-print/services/pretty-print.service.ts
Outdated
Show resolved
Hide resolved
packages/stark-ui/src/modules/pretty-print/services/pretty-print.service.ts
Outdated
Show resolved
Hide resolved
mhenkens
force-pushed
the
feature/prettier3
branch
4 times, most recently
from
2e378d0 to
d47412d
Compare
SuperITMan
requested changes
Dec 22, 2023
packages/stark-ui/src/modules/pretty-print/components/pretty-print.component.ts
Outdated
Show resolved
Hide resolved
packages/stark-ui/src/modules/pretty-print/components/pretty-print.component.ts
Outdated
Show resolved
Hide resolved
packages/stark-ui/src/modules/pretty-print/components/pretty-print.component.ts
Outdated
Show resolved
Hide resolved
packages/stark-ui/src/modules/pretty-print/components/pretty-print.component.ts
Outdated
Show resolved
Hide resolved
packages/stark-ui/src/modules/pretty-print/components/pretty-print.component.ts
Outdated
Show resolved
Hide resolved
packages/stark-ui/src/modules/pretty-print/components/pretty-print.component.spec.ts
Outdated
Show resolved
Hide resolved
packages/stark-ui/src/modules/pretty-print/components/pretty-print.component.spec.ts
Show resolved
Hide resolved
packages/stark-ui/src/modules/pretty-print/components/pretty-print.component.ts
Outdated
Show resolved
Hide resolved
packages/stark-ui/src/modules/pretty-print/components/pretty-print.component.ts
Outdated
Show resolved
Hide resolved
packages/stark-ui/src/modules/pretty-print/components/pretty-print.component.spec.ts
Outdated
Show resolved
Hide resolved
mhenkens
force-pushed
the
feature/prettier3
branch
from
d47412d to
8a9ac12
Compare
Because the prettier.format is now async, we need to change the way we handle the format function We create a service to handle the asynchronous call We need to remove `@prettier/plugin-xml` because we cannot make it run in standalone. To format xml data we use `html` parser
mhenkens
force-pushed
the
feature/prettier3
branch
from
8a9ac12 to
323d8cd
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the prettier.format is now async, we need to change the way we handle the format function We create a service to handle this
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
update prettier to prettier 3.1
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information