Merge pull request #3612 from mhenkens/test/eslint

Change Linting engine from `TSLint` to `ESLint`

.cz-config.js

@@ -26,8 +26,7 @@ module.exports = {
 		},
 		{
 			value: "ci",
-			name:
-				"ci:     Changes to our CI configuration files and scripts (example scopes: GitHub Actions, Circle, BrowserStack, SauceLabs)"
+			name: "ci:     Changes to our CI configuration files and scripts (example scopes: GitHub Actions, Circle, BrowserStack, SauceLabs)"
 		},
 		{
 			value: "chore",

.eslintrc.json

@@ -0,0 +1,17 @@
+{
+  "root": true,
+  "extends": ["@nationalbankbelgium", "prettier"],
+  "overrides": [
+    {
+      "files": ["*.ts"],
+      "plugins": ["eslint-plugin-sonarjs"],
+      "extends": ["plugin:sonarjs/recommended"]
+    },
+    {
+      "files": ["*.spec.ts"],
+      "rules": {
+        "sonarjs/no-duplicate-string": "off"
+      }
+    }
+  ]
+}

.github/ISSUE_TEMPLATE.md

@@ -1,6 +1,7 @@
 <!-- Note: for support questions please use Stack Overflow: https://stackoverflow.com/questions/tagged/stark -->
 
 ## I'm submitting a...
+
 <!-- Check one of the following options with "x" -->
 <pre><code>
 [ ] Regression (a behavior that used to work and stopped working in a new release)
@@ -11,23 +12,23 @@
 </code></pre>
 
 ## Current behavior
-<!-- Describe how the issue manifests. -->
 
+<!-- Describe how the issue manifests. -->
 
 ## Expected behavior
-<!-- Describe what the desired behavior would be. -->
 
+<!-- Describe what the desired behavior would be. -->
 
 ## Minimal reproduction of the problem with instructions
+
 <!--
 For bug reports please provide a *MINIMAL DEMO* of the problem via https://plnkr.co or
 provide a standalone git repository demonstrating the problem
 -->
 
-
 ## What is the motivation / use case for changing the behavior?
-<!-- Describe the motivation or the concrete use case. -->
 
+<!-- Describe the motivation or the concrete use case. -->
 
 ## Environment
 
@@ -52,4 +53,4 @@ For Tooling issues:
 
 Others:
 <!-- Anything else relevant?  Operating system version, IDE, package manager, HTTP server, ... -->
-</code></pre>
+</code></pre>

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,15 +1,17 @@
 ## PR Checklist
+
 Please check if your PR fulfills the following requirements:
 
 - [ ] The commit message follows our guidelines: https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#-commit-message-guidelines
 - [ ] Tests for the changes have been added (for bug fixes / features)
 - [ ] Docs have been added / updated (for bug fixes / features)
 
-
 ## PR Type
+
 What kind of change does this PR introduce?
 
 <!-- Please check the one that applies to this PR using "x". -->
+
 ```
 [ ] Bugfix
 [ ] Feature
@@ -22,21 +24,20 @@ What kind of change does this PR introduce?
 ```
 
 ## What is the current behavior?
+
 <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->
 
 Issue Number: N/A
 
-
 ## What is the new behavior?
 
-
 ## Does this PR introduce a breaking change?
+
 ```
 [ ] Yes
 [ ] No
 ```
 
 <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->
 
-
-## Other information
+## Other information

angular.json

@@ -25,10 +25,9 @@
           }
         },
         "lint": {
-          "builder": "@angular-devkit/build-angular:tslint",
+          "builder": "@angular-eslint/builder:lint",
           "options": {
-            "tsConfig": ["./packages/stark-core/tsconfig.lib.json", "./packages/stark-core/tsconfig.spec.json"],
-            "exclude": ["**/node_modules/**"]
+            "lintFilePatterns": ["./packages/stark-core/**/*.ts", "./packages/stark-core/**/*.html"]
           }
         }
       }
@@ -85,10 +84,9 @@
           }
         },
         "lint": {
-          "builder": "@angular-devkit/build-angular:tslint",
+          "builder": "@angular-eslint/builder:lint",
           "options": {
-            "tsConfig": ["./packages/stark-ui/tsconfig.lib.json", "./packages/stark-ui/tsconfig.spec.json"],
-            "exclude": ["**/node_modules/**"]
+            "lintFilePatterns": ["./packages/stark-ui/**/*.ts", "./packages/stark-ui/**/*.html"]
           }
         }
       }