-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infogulch elaboration #6
base: master
Are you sure you want to change the base?
Conversation
… the same as it will ingame. Several other changes
…am if you want to)
…rd the fraction part, but rounds to the nearest integer
…am (and not to spectator unless the team is locked)
If a command throws an actual error it is now printed to the console.
New property is `connection.total_blocks_destroyed`. It should only be read from, not written to. If you want to know how many blocks was destroyed at one specific time, save the current count in a temporary variable and take the difference.
This is quite a lot of loose stuff for a single PR I think, some of which is completely unnecessary, such as the IP. Might possibly be some redundant commits as well. I'll have to dig through this is a bit more. |
Ok, I left |
@noway421 I've been working on a fork of this project with the aim of tidying it up and experimenting (with things like porting to python3, depending on vanilla upstream pyenet) at swalladge/PySnip. I'm open to any radicale changes and improvements, so feel free to submit pull requests to it or contact me if you are still working on the project. :) |
nice, good luck with that |
@swalladge I like the config refactoring. If you'd like, feel free to submit a PR here for it. I'm going to sift through all of these changes here and merge where possible. |
@NateShoffner sure, will do. 👍 |
There are a lot of changes, but i'm confident that they are safe for pysnip.
Most of them are edits for userscripts.
Most nasty stuff going on in commands.py and in cython/native files (
vxl.pxd
,vxl.pyx
,vxl_c.cpp
,vxl_c.h
,world_c.cpp
).Changes in pyspades editor are also huge, but for me they are fine (I used this version of pyspades editor, nothing unordinary)
Merge conflicts were in
pyspades/master.py
(different whatismyipapi site),.gitignore
,config.txt
,contrib/
directory.Otherwise everything looks perfectly fine.