Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to php library dependencies #1698

Merged
merged 7 commits into from
Oct 10, 2024
Merged

Updates to php library dependencies #1698

merged 7 commits into from
Oct 10, 2024

Conversation

joelit
Copy link
Contributor

@joelit joelit commented Oct 9, 2024

Reasons for creating this PR

Library dependencies need to be inspected periodically to keep the PHP codebase up-to-date

Description of the changes in this PR

Changes to composer.json. The changes can be implemented by running php composer.phar update. Remaining work can be inspected by running php composer.phar outdated. Possible vulnerabilitiy reports can be inspected by running php composer.phar audit.

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@joelit joelit added the maintenance Dependency changes, security updates, infrastructure tweaks & general mainenance label Oct 9, 2024
@joelit joelit added this to the 3.0 milestone Oct 9, 2024
@joelit joelit self-assigned this Oct 9, 2024
@joelit joelit marked this pull request as ready for review October 9, 2024 13:22
@osma
Copy link
Member

osma commented Oct 10, 2024

PHPUnit now shows these warnings:

There were 6 warnings:

1) ConceptPropertyValueLiteralTest::testGetLabelThatIsABrokenDate
Expecting E_WARNING and E_USER_WARNING is deprecated and will no longer be possible in PHPUnit 10.

2) ConceptTest::testGetTimestampInvalidWarning
Expecting E_ERROR and E_USER_ERROR is deprecated and will no longer be possible in PHPUnit 10.

3) VocabularyConfigTest::testGetDefaultLanguageWhenNotSet
Expecting E_ERROR and E_USER_ERROR is deprecated and will no longer be possible in PHPUnit 10.

4) VocabularyConfigTest::testGetDataURLsNotGuessable
Expecting E_WARNING and E_USER_WARNING is deprecated and will no longer be possible in PHPUnit 10.

5) VocabularyConfigTest::testGetDataURLsMarcNotDefined
Expecting E_WARNING and E_USER_WARNING is deprecated and will no longer be possible in PHPUnit 10.

6) VocabularyConfigTest::testGetPropertyOrderUnknown
Expecting E_WARNING and E_USER_WARNING is deprecated and will no longer be possible in PHPUnit 10.

This can also be seen in the CI runs, e.g. this one.

I think these should be fixed in this PR. It would make future PHPUnit upgrades easier...

Copy link
Member

@osma osma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally and also looked at the changelogs for the upgraded components. I'm a little uneasy about upgrading symfony/translation-contracts, but it seems to work, so I'm fine with that.

I think the PHPUnit warnings should be fixed (see above comment), otherwise good to merge!

Copy link

sonarcloud bot commented Oct 10, 2024

@joelit joelit merged commit 84b37b4 into main Oct 10, 2024
9 checks passed
@joelit joelit deleted the dependency-updates branch October 10, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Dependency changes, security updates, infrastructure tweaks & general mainenance
Projects
Status: Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR)
Development

Successfully merging this pull request may close these issues.

2 participants