-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to php library dependencies #1698
Conversation
…t does not break the tests
PHPUnit now shows these warnings:
This can also be seen in the CI runs, e.g. this one. I think these should be fixed in this PR. It would make future PHPUnit upgrades easier... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this locally and also looked at the changelogs for the upgraded components. I'm a little uneasy about upgrading symfony/translation-contracts, but it seems to work, so I'm fine with that.
I think the PHPUnit warnings should be fixed (see above comment), otherwise good to merge!
Quality Gate passedIssues Measures |
Reasons for creating this PR
Library dependencies need to be inspected periodically to keep the PHP codebase up-to-date
Description of the changes in this PR
Changes to composer.json. The changes can be implemented by running
php composer.phar update
. Remaining work can be inspected by runningphp composer.phar outdated
. Possible vulnerabilitiy reports can be inspected by runningphp composer.phar audit
..sr-only
class, color contrast)