Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CheckA11y function parameters with nulls and cypress folder tuning #1506

Conversation

miguelvaara
Copy link
Contributor

Reasons for creating this PR

A table that presents accessibility errors more effectively is necessary, even though SonarCloud reports the error. Additionally, the 'screenshots' and 'videos' directories should be in the correct test directory.

Link to relevant issue(s), if any

  • Closes #

Description of the changes in this PR

--- a/cypress.config.js
+++ b/cypress.config.js
@@ -22,6 +22,8 @@ module.exports = defineConfig({
'tests/cypress/accessibility//*.cy.js',
'tests/cypress/template/
/.cy.js',
'tests/cypress/e2e/**/
.cy.js'

  • ]
  • ],
  • screenshotsFolder: 'tests/cypress/screenshots',
  • videosFolder: 'tests/cypress/videos'
    }
    })

AND

--- a/tests/cypress/support/accessibility.js
+++ b/tests/cypress/support/accessibility.js
@@ -39,7 +39,7 @@ function getConfigurationForCLITests () {
}
function getConfigurationForGUITests () {
return it('Check for possible accessibility errors at all logging levels set below in accordance with WCAG AA requirements', () => {

  • checkA11y({
  • checkA11y(null, null, {
    includedImpacts: ['minor', 'moderate', 'serious', 'critical'],
    runOnly: {
    type: 'tag',

Known problems or uncertainties in this PR

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

… changes have been made to the Cypress folder structure.
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.04% 🎉

Comparison is base (76def2f) 70.05% compared to head (9cc7d01) 70.09%.
Report is 4 commits behind head on skosmos-3.

Additional details and impacted files
@@               Coverage Diff               @@
##             skosmos-3    #1506      +/-   ##
===============================================
+ Coverage        70.05%   70.09%   +0.04%     
  Complexity        1641     1641              
===============================================
  Files               32       32              
  Lines             4301     4301              
===============================================
+ Hits              3013     3015       +2     
+ Misses            1288     1286       -2     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miguelvaara miguelvaara changed the base branch from master to skosmos-3 August 31, 2023 09:29
@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@miguelvaara miguelvaara merged commit 4a7dd14 into skosmos-3 Aug 31, 2023
8 of 10 checks passed
@miguelvaara miguelvaara changed the title Checka11y function parameters with nulls and cypress folder tuning CheckA11y function parameters with nulls and cypress folder tuning Aug 31, 2023
@osma osma deleted the checka11y-function-parameters-with-nulls-and-cypress-folder-tuning branch October 10, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR)
Development

Successfully merging this pull request may close these issues.

2 participants