Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some features #183

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix some features #183

wants to merge 6 commits into from

Conversation

Mantouisyummy
Copy link
Collaborator

@Mantouisyummy Mantouisyummy commented Oct 20, 2024

as title.

Key Updates:

  • Enabled autoplay for non-YouTube sources
  • Fixed some issues with autoplay
  • Changed the search source from YouTube Music to YouTube
  • Replace 'syncedlyrics' with a custom asynchronous version.

Copy link
Contributor

deepsource-io bot commented Oct 20, 2024

Here's the code health analysis summary for commits c62826f..c7cffd1. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why "ytmsearch" was changed to "ytsearch"? This was to make the lyrics feature work better.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two reasons for changing to 'ytsearch':

  1. The displayed song titles (such as in Chinese) will no longer appear in English just because it’s from YouTube Music.
  2. Once the song titles are displayed according to the correct language, the lyrics search will become more accurate, avoiding the issue of showing English lyrics and song titles when searching for Chinese songs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants