Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for windows generated trx #268

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

remoteexception
Copy link

No description provided.

Jana Storch and others added 2 commits December 13, 2022 12:45
Copy link
Owner

@NasAmin NasAmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR to make this action better and apologies for the delay.

Comment on lines -17 to +19
run: npm ci
run: |
# todo: resolve npm dependency conflicts and than remove the --legacy-peer-deps option
npm ci --legacy-peer-deps
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed the peer deps, can you please rebase from main and revert this change?

<ResultSummary outcome="Completed">
<Counters total="1" executed="1" passed="1" failed="0" error="0" timeout="0" aborted="0" inconclusive="0" passedButRunAborted="0" notRunnable="0" notExecuted="0" disconnected="0" warning="0" completed="0" inProgress="0" pending="0" />
</ResultSummary>
</TestRun>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Insert a new line please.

src/utils.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants