Include scan code when simulating keyboard events on Windows #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@isaackd very nice. Not having a windows machine at hand (only remote ones which don't make testing this easy), I would love if someone could confirm/infirm this PR is indeed working. |
|
The other PR looks more complete, but thereś a lot of weird values and switches going on, which are probably a tiny bit too platform specific. Either windows document those values (and they are usually in the lib as flags) and we need to link that, or they are not and I wouldn't include them. Your PR looks better imo. |
pentamassiv
reviewed
Apr 18, 2024
| use winapi::um::winuser::{MapVirtualKeyA, MAPVK_VK_TO_VSC}; | ||
|
|
||
| pub fn scan_from_code(code: WORD) -> Option<WORD> { | ||
| let scan = unsafe { MapVirtualKeyA(code as u32, MAPVK_VK_TO_VSC) } as WORD; |
There was a problem hiding this comment.
I think this should be either MapVirtualKey or MapVirtualKeyW instead (source)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to get keypresses detected by Factorio I noticed it would only work when the proper scan codes are included in the call to
SendInput.This should also fix #73 according to rustdesk/rustdesk#366 (comment).
I'm not super familiar with the Windows API and came across a more complete-looking implementation at https://github.com/fufesou/rdev/blob/560eb62adfaa1e53b77d80800904b3241812e284/src/windows/simulate.rs#L116-L134, but maybe this PR is a good starting point?