Concatenate all js files on the fly without specifying files names #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will really concatenate files without having to name them. File list is parsed from html file. In our case, this will be perfect for sites fully Angular.js
Forgot to add this : $settings['htmlMinifier'] = 'html';
We handle concatenation of js files.
Try to speedup things optimizing all comparisons with === and !== instead of == and !=
Missed few optimisations
Try to optimize comparisons in loops with === and !==. No noticable improvements when profiling, but each milliseconds winned are important
Avoid to evaluation strlen($str) each time. Few milliseconds won
Avoid to evaluate strlen($str) each time. Few milliseconds won.
Removed this : $settings['alljs'];
NULL give the following Warning on PHP > 5.5 : PHP Warning: Unknown: function 'NULL' not found or invalid function name in Unknown on line 0 None solve the problem.
|
Few optimisations and .htaccess modified to avoid Warning about NULL function |
Updated to packer 1.3 from this address : https://github.com/ptcong/javascript-packer Sadly this doesn't solve problem packing angular.js with wamp/xampp php server.
Modifications for css grouping
Modifications for Css grouping
Modifications for Css grouping
We skip scripts with http:// or https:// in path (instead of only http:// in path)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch to concatenate all js files on the fly without naming them.
Note that css concatenation is broken, but css files should be loaded asynchronously to be compliant with : https://developers.google.com/speed/pagespeed/insights/
I will try to add this later.
Regards,
SixK