Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a core dump on startup and warning on rexexp search for version number #707

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

t52ta6ek
Copy link
Contributor

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • [] Feature
  • [] Code style update (formatting, renaming)
  • [] Refactoring (no functional changes, no API changes)
  • [] Build-related changes
  • Documentation content changes
  • [] Other (please describe):

What is the current behavior?

Performed a virgin install of Lubuntu 24.04 LTS and followed the steps in INSTALLATION.md to create the python3 virtual environment. Starting nanovna-saver app resulted in core dump. Seems the culprit is a missing installation of libxcb-cursur-dev. Once that installed, nanovna-saver app start and runs.

Notices a warning in checking for updates. Fixed my regexp search as well.

Issue Number: N/A

What is the new behavior?

Application run starts up and runs without core dumping or emitting warning about regexp.

Does this introduce a breaking change?

  • [] Yes
  • No

Other information

Added libxcb-cursor-dev to correct startup error:
Could not load the Qt platform plugin "xcb" in "" even though it was found.
...and its resulting core dump.
Fixes warning on startup.
@t52ta6ek t52ta6ek requested a review from zarath as a code owner June 27, 2024 16:36
Copy link
Collaborator

@zarath zarath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See code comment in About.py

src/NanoVNASaver/Windows/About.py Outdated Show resolved Hide resolved
@zarath zarath merged commit f3f1ed0 into NanoVNA-Saver:main Jul 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants