Remove obsolete code from Food, Drink and Respirator systems. (#30560) #3
NakataRinAnnotations
32 warnings
|
Test Packaging
The following actions uses node12 which is deprecated and will be forced to run on node16: space-wizards/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Test Packaging
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/[email protected], space-wizards/[email protected], actions/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Utility/MarkupNode.cs#L10
'MarkupNode' overrides Object.Equals(object o) but does not override Object.GetHashCode()
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Containers/ContainerManagerComponent.cs#L33
'Component.Owner' is obsolete: 'Update your API to allow accessing Owner through other means'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Containers/SharedContainerSystem.cs#L590
'SharedContainerSystem.TryGetContainingContainer(EntityUid, out BaseContainer?, MetaDataComponent?, TransformComponent?)' is obsolete: 'Use Entity<T> variant'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Containers/SharedContainerSystem.cs#L660
'SharedContainerSystem.TryGetContainingContainer(EntityUid, out BaseContainer?, MetaDataComponent?, TransformComponent?)' is obsolete: 'Use Entity<T> variant'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Containers/SharedContainerSystem.cs#L673
'SharedContainerSystem.TryGetContainingContainer(EntityUid, out BaseContainer?, MetaDataComponent?, TransformComponent?)' is obsolete: 'Use Entity<T> variant'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/ProfileOptSetup.cs#L16
Unreachable code detected
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Prototypes/PrototypeManager.YamlValidate.cs#L72
The variable 'defaultErrorOccurred' is assigned but its value is never used
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Physics/Systems/SharedPhysicsSystem.Contacts.cs#L627
'SharedPhysicsSystem.SetAwake(EntityUid, PhysicsComponent, bool, bool)' is obsolete: 'Use SetAwake with EntityUid<PhysicsComponent>'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Physics/Systems/SharedPhysicsSystem.Contacts.cs#L628
'SharedPhysicsSystem.SetAwake(EntityUid, PhysicsComponent, bool, bool)' is obsolete: 'Use SetAwake with EntityUid<PhysicsComponent>'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Physics/Systems/SharedPhysicsSystem.Island.cs#L325
'Component.Owner' is obsolete: 'Update your API to allow accessing Owner through other means'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Utility/MarkupNode.cs#L10
'MarkupNode' overrides Object.Equals(object o) but does not override Object.GetHashCode()
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Containers/SharedContainerSystem.cs#L590
'SharedContainerSystem.TryGetContainingContainer(EntityUid, out BaseContainer?, MetaDataComponent?, TransformComponent?)' is obsolete: 'Use Entity<T> variant'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Containers/SharedContainerSystem.cs#L660
'SharedContainerSystem.TryGetContainingContainer(EntityUid, out BaseContainer?, MetaDataComponent?, TransformComponent?)' is obsolete: 'Use Entity<T> variant'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Containers/SharedContainerSystem.cs#L673
'SharedContainerSystem.TryGetContainingContainer(EntityUid, out BaseContainer?, MetaDataComponent?, TransformComponent?)' is obsolete: 'Use Entity<T> variant'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Containers/ContainerManagerComponent.cs#L33
'Component.Owner' is obsolete: 'Update your API to allow accessing Owner through other means'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/ProfileOptSetup.cs#L16
Unreachable code detected
|
|
Test Packaging:
RobustToolbox/Robust.Shared/GameObjects/Systems/SharedTransformSystem.Component.cs#L761
'TransformComponent.Anchored.set' is obsolete: 'Use the SharedTransformSystem.AnchorEntity/Unanchor methods instead.'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/GameObjects/Systems/SharedTransformSystem.Component.cs#L1079
'SharedTransformSystem.SetLocalRotation(TransformComponent, Angle)' is obsolete: 'use override with EntityUid'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/GameObjects/Systems/SharedTransformSystem.Component.cs#L1093
'SharedTransformSystem.SetLocalRotation(TransformComponent, Angle)' is obsolete: 'use override with EntityUid'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/GameObjects/Systems/SharedMapSystem.Coordinates.cs#L26
'EntityCoordinates.ToMap(IEntityManager, SharedTransformSystem)' is obsolete: 'Use SharedTransformSystem.ToMapCoordinates()'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Utility/MarkupNode.cs#L10
'MarkupNode' overrides Object.Equals(object o) but does not override Object.GetHashCode()
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Containers/SharedContainerSystem.cs#L590
'SharedContainerSystem.TryGetContainingContainer(EntityUid, out BaseContainer?, MetaDataComponent?, TransformComponent?)' is obsolete: 'Use Entity<T> variant'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Containers/SharedContainerSystem.cs#L660
'SharedContainerSystem.TryGetContainingContainer(EntityUid, out BaseContainer?, MetaDataComponent?, TransformComponent?)' is obsolete: 'Use Entity<T> variant'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Containers/SharedContainerSystem.cs#L673
'SharedContainerSystem.TryGetContainingContainer(EntityUid, out BaseContainer?, MetaDataComponent?, TransformComponent?)' is obsolete: 'Use Entity<T> variant'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Player/Filter.cs#L289
'EntitySystem.TryGet<T>(out T?)' is obsolete: 'Either use a dependency, resolve and cache IEntityManager manually, or use EntityManager.System<T>()'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Toolshed/TypeParsers/SessionTypeParser.cs#L46
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Toolshed/TypeParsers/SessionTypeParser.cs#L57
'FormattedMessage.FromMarkup(string)' is obsolete: 'Use FromMarkupOrThrow or TryFromMarkup'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Toolshed/TypeParsers/QuantityTypeParser.cs#L67
'FormattedMessage.FromMarkup(string)' is obsolete: 'Use FromMarkupOrThrow or TryFromMarkup'
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Prototypes/PrototypeManager.YamlValidate.cs#L72
The variable 'defaultErrorOccurred' is assigned but its value is never used
|
|
Test Packaging:
RobustToolbox/Robust.Shared/Containers/ContainerManagerComponent.cs#L33
'Component.Owner' is obsolete: 'Update your API to allow accessing Owner through other means'
|