Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README.md to include object compare #94

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

designxtek
Copy link

In reference to #93 on verifying calls with objects

@NagRock
Copy link
Owner

NagRock commented Mar 13, 2018

What do you think about separate section in readme.md about matchers?

@designxtek
Copy link
Author

Yeah I could create a separate section. I'm not too familiar with it but I can start something.

@NagRock
Copy link
Owner

NagRock commented Mar 13, 2018

Would be great

@designxtek
Copy link
Author

Added a new section. Let me know if there is any other changes needed. Thanks

@codecov-io
Copy link

Codecov Report

Merging #94 into master will increase coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
+ Coverage   94.58%   94.89%   +0.31%     
==========================================
  Files          35       34       -1     
  Lines         609      607       -2     
  Branches       69       69              
==========================================
  Hits          576      576              
+ Misses         24       22       -2     
  Partials        9        9
Impacted Files Coverage Δ
src/stub/MethodStub.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93d6625...996b81f. Read the comment docs.

@yankeeinlondon
Copy link

@NagRock I just started using this library yesterday so i'm a newbie but wondering about PR's like this which pass all tests and were introduced over a year ago. Is this library still being supported? Just a bit worried I may have gotten to the party too late 😆

@avneesh91
Copy link

@NagRock Can we please merge this, I think a lot of people will go through this issue(and would help to save a lot of time).

Thanks.

@henrikra
Copy link

Good to merge!

@alexanderfokau
Copy link

Merge when?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants