Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue of toggle button doesn't closes automatically in mobile view #91 #102

Merged

Conversation

kaali001
Copy link
Contributor

Related Issue

None

Description

In the mobile view of the website, when clicking on the Login or Signup buttons in the navbar, the toggle button does not automatically close. This results in the toggle menu remaining open even after selecting one of the options, causing a poor user experience.

So I have fixed this issue by adding some missing functions in the MenuOverlay.jsx file.

Type of PR

  • [ X] Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

Screenshot with issues -
image

Screenshot of fixed issues -
image

Checklist:

  • [ X] I have performed a self-review of my code
  • [ X] I have read and followed the Contribution Guidelines.
  • [ X] I have tested the changes thoroughly before submitting this pull request.
  • [X ] I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • [X ] I have commented my code, particularly in hard-to-understand areas.

Additional context:

Issue arises because of missing onClick={handleClick} in both the buttons (login/signup) in the MenuOverlay.jsx file.

Copy link

vercel bot commented May 21, 2024

@kaali001 is attempting to deploy a commit to the Nactore Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @kaali001! 🎉 Thank you for submitting your pull request. Your contribution is valuable, and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nacto-care ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 10:23pm

@Harshil-Jani Harshil-Jani merged commit fc414e4 into Nactore-Org:main May 21, 2024
3 checks passed
@kaali001 kaali001 deleted the fix/Automatic-toggle-Btn-Not-closing branch May 22, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants