IOS-631 Fix crash when Publication::baseURL is nil #1629
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this do?
precondition
statement in an initializer of an internal class (EPUBNavigatorViewModel
)successCompletion
handler into a regularcompletion(_:Bool)
handler called for failure cases too.Why are we doing this? (w/ JIRA link if applicable)
IOS-631
How should this be tested? / Do these changes have associated tests?
We never determined a reproducible case for this crash. I'd say we should verify book opening does not present any regressions.
Dependencies for merging? Releasing to production?
this is dependent on #1628
Once that is merged I will change the base branch to
develop
.Does this include changes that require a new SimplyE/Open eBooks build for QA?
not yet
Has the application documentation been updated for these changes?
yes
Did someone actually run this code to verify it works?
I did