Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS-631 Fix crash when Publication::baseURL is nil #1629

Merged
merged 4 commits into from
Feb 5, 2024

Conversation

ettore
Copy link
Collaborator

@ettore ettore commented Feb 1, 2024

What's this do?

  • fixes a crash happening because Readium has a precondition statement in an initializer of an internal class (EPUBNavigatorViewModel)
  • fixing the crash involves not opening the reader and presenting an error message. This caused a spinner on the "Read" button to never stop spinning. The 2nd commit addresses this UX problem by converting a successCompletion handler into a regular completion(_:Bool) handler called for failure cases too.

Why are we doing this? (w/ JIRA link if applicable)
IOS-631

How should this be tested? / Do these changes have associated tests?
We never determined a reproducible case for this crash. I'd say we should verify book opening does not present any regressions.

Dependencies for merging? Releasing to production?
this is dependent on #1628
Once that is merged I will change the base branch to develop.

Does this include changes that require a new SimplyE/Open eBooks build for QA?
not yet

Has the application documentation been updated for these changes?
yes

Did someone actually run this code to verify it works?
I did

@ettore ettore force-pushed the IOS-631/publicationBaseURL-crash branch from c988f1d to 8253df8 Compare February 5, 2024 18:13
Base automatically changed from IOS-639/xcode15 to develop February 5, 2024 18:34
@ettore ettore force-pushed the IOS-631/publicationBaseURL-crash branch from 49b4653 to 84b2f0e Compare February 5, 2024 20:11
@ettore ettore force-pushed the IOS-631/publicationBaseURL-crash branch from 84b2f0e to 0be29ae Compare February 5, 2024 22:29
@ettore ettore merged commit 229e326 into develop Feb 5, 2024
2 checks passed
@ettore ettore deleted the IOS-631/publicationBaseURL-crash branch February 5, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants