Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS-583 / IOS-567 Upgrade tooling to Xcode 14.3 #1624

Merged
merged 8 commits into from
Oct 12, 2023

Conversation

ettore
Copy link
Collaborator

@ettore ettore commented Oct 11, 2023

What's this do?

  • Removed R2dev target (once used for Readium integration)
  • move Readium, Crashlytics and SQLite integration from Carthage to SPM. Carthage is now limited to just 2 packages unsupported via SPM.
  • One of these 2 packages is ZXingObjC, which no longer compiled. So I forked it and did some quick fixes (update to iOS 11 minimum target, few api updates). I did not verify these fixes beyond compilation.
    • the fork is still on my user, but we could move this to NYPL at some later point?
  • Disable Open eBooks CI checks for now
  • Fix SimplyE-no-drm target (this required to add SQLite explicitly which was not required for SimplyE target: I did not understand why)
  • Update all projects/submodules to Xcode 14.3

There are still a number of warnings that will be addressed in future PRs.

Why are we doing this? (w/ JIRA link if applicable)
https://jira.nypl.org/browse/IOS-567
https://jira.nypl.org/browse/IOS-583

How should this be tested? / Do these changes have associated tests?
n/a

Dependencies for merging? Releasing to production?
this depends on NYPL-Simplified/readium-sdk#10
not releasing to prod

Does this include changes that require a new SimplyE/Open eBooks build for QA?
no

Has the application documentation been updated for these changes?
yes

Did someone actually run this code to verify it works?
yes (@ettore)

Also update ZXingObjC to a fork that includes fixes for Xcode 14.3 and min deployment target: old project was supporting down to iOS 8, but current Xcode only supports down to iOS 11.
Also remove dSYM push to Crashlytics from no-drm build
@ettore ettore force-pushed the IOS-567/upgrade-tooling branch 2 times, most recently from dc7f6a3 to 19d7385 Compare October 11, 2023 23:45
@ettore ettore changed the title Ios 567/upgrade tooling IOS-583 / IOS-567 Upgrade tooling to Xcode 14.3 Oct 11, 2023
@ettore ettore marked this pull request as ready for review October 11, 2023 23:52
@ettore ettore merged commit 6596d36 into develop Oct 12, 2023
2 checks passed
@ettore ettore deleted the IOS-567/upgrade-tooling branch October 12, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants