997 fix zoning hyperlinks c3 #1028
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Refactor function to work with all zoning codes;
allthesignals
force-pushed
the
997-fix-zoning-hyperlinks-c3
branch
from
360275b
to
c6609e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #997
Centralizes zoning district link (dcp website) generation logic into the zoning district model. Before, it was split out into multiple places.
The tax lot model now imports that logic from the zoning district model.
Also, before,
primaryzonewas the name used to build the DCP zoning district. This isn't really what it is... it applies logic to generate links from a givenzonedistinto idiosyncratic dcp website URLs.As for the original bug... the lookup was case sensitive. So, it wasn't able to apply the link-generation logic. For example, "C2" is not "c2". This PR adds some case insensitive string comparison.